Fix automock for numeric function names#7653
Merged
Merged
Conversation
SimenB
approved these changes
Jan 19, 2019
SimenB
left a comment
SimenB
left a comment
Member
There was a problem hiding this comment.
Thanks! I was unaware we already had logic for this, turned out really clean
| expect( | ||
| getMockFnWithOriginalName('foo𠮷bar').name === 'foo𠮷bar', | ||
| ).toBeTruthy(); | ||
| expect(getMockFnWithOriginalName('1').name).toBe('$1'); |
Co-Authored-By: jeysal <seckinger.tim@gmail.com>
thymikee
added a commit
to thymikee/jest
that referenced
this pull request
Jan 20, 2019
…m-runtime * upstream/master: add missing truncate comment to recent blog posts (jestjs#7655) use raw serializer for e2e output snapshots (jestjs#7651) chore: use a Set for reserved words list in `jest-mock` Fix automock for numeric function names (jestjs#7653) Update docs re: `moduleFileExtensions` to add ordering note (left-to-right) (jestjs#7616)
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7624
Test plan
Added one assertion for the name itself and
added one test case that should closely resembles #7624