Skip to content

expect: Improve report when assertion fails, part 6 #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrottimark merged 15 commits into from
Jan 20, 2019
Merged

expect: Improve report when assertion fails, part 6 #7621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f04e1b1
expect: Improve report when assertion fails, part 6
pedrottimark Jan 13, 2019
eb7902d
Merge dependency upgrades especially flow
pedrottimark Jan 13, 2019
f09ad0a
Fix flow errors
pedrottimark Jan 13, 2019
9747691
Move new function to reduce noise in diff
pedrottimark Jan 13, 2019
2a46840
Update CHANGELOG.md
pedrottimark Jan 14, 2019
39daf2c
Convert ANSI codes in promise/async snapshots
pedrottimark Jan 14, 2019
fc766f1
Rewrite promise/async snapshot tests
pedrottimark Jan 14, 2019
495db2f
Reduce length of labels and handle non-error values
pedrottimark Jan 16, 2019
0c94113
Add tests for non-error values
pedrottimark Jan 16, 2019
44118a3
Fix prettier lint error
pedrottimark Jan 16, 2019
6d8a416
Update ExpectAPI.md
pedrottimark Jan 16, 2019
d576e72
Improve grammar in ExpectAPI.md
pedrottimark Jan 16, 2019
4218be0
Delete an exception from Received function did not throw
pedrottimark Jan 16, 2019
4ea8044
Correct typo in ExpectAPI.md
pedrottimark Jan 16, 2019
2a3f1c8
Correct type and report for non-error class
pedrottimark Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions packages/expect/src/__tests__/__snapshots__/toThrowMatchers.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,29 +49,29 @@ Expected has value: <green>111</>"
`;

exports[`.toThrow() promise/async throws if Error-like object is returned did not throw at all 1`] = `
[Error: expect(received).rejects.toThrow()
"<dim>expect(</><red>received</><dim>).</>rejects<dim>.</>toThrow<dim>()</>

Received function did not throw an exception]
Received function did not throw an exception"
`;

exports[`.toThrow() promise/async throws if Error-like object is returned threw, but class did not match 1`] = `
[Error: expect(received).rejects.toThrow(expected)
"<dim>expect(</><red>received</><dim>).</>rejects<dim>.</>toThrow<dim>(</><green>expected</><dim>)</>

Expected error name: "Err2"
Received error name: "Error"
Expected error name: <green>\\"Err2\\"</>
Received error name: <red>\\"Error\\"</>

Received error message: "async apple"
Received error message: <red>\\"async apple\\"</>

at jestExpect (packages/expect/src/__tests__/toThrowMatchers-test.js:24:74)]
<dim>at jestExpect (</>packages/expect/src/__tests__/toThrowMatchers-test.js<dim>:24:74)</>"
`;

exports[`.toThrow() promise/async throws if Error-like object is returned threw, but should not have 1`] = `
[Error: expect(received).rejects.not.toThrow()
"<dim>expect(</><red>received</><dim>).</>rejects<dim>.</>not<dim>.</>toThrow<dim>()</>

Received error name: "Error"
Received error message: "async apple"
Received error name: <red>\\"Error\\"</>
Received error message: <red>\\"async apple\\"</>

at jestExpect (packages/expect/src/__tests__/toThrowMatchers-test.js:24:74)]
<dim>at jestExpect (</>packages/expect/src/__tests__/toThrowMatchers-test.js<dim>:24:74)</>"
`;

exports[`.toThrow() regexp did not throw at all 1`] = `
Expand Down Expand Up @@ -175,29 +175,29 @@ Expected has value: <green>111</>"
`;

exports[`.toThrowError() promise/async throws if Error-like object is returned did not throw at all 1`] = `
[Error: expect(received).rejects.toThrowError()
"<dim>expect(</><red>received</><dim>).</>rejects<dim>.</>toThrowError<dim>()</>

Received function did not throw an exception]
Received function did not throw an exception"
`;

exports[`.toThrowError() promise/async throws if Error-like object is returned threw, but class did not match 1`] = `
[Error: expect(received).rejects.toThrowError(expected)
"<dim>expect(</><red>received</><dim>).</>rejects<dim>.</>toThrowError<dim>(</><green>expected</><dim>)</>

Expected error name: "Err2"
Received error name: "Error"
Expected error name: <green>\\"Err2\\"</>
Received error name: <red>\\"Error\\"</>

Received error message: "async apple"
Received error message: <red>\\"async apple\\"</>

at jestExpect (packages/expect/src/__tests__/toThrowMatchers-test.js:24:74)]
<dim>at jestExpect (</>packages/expect/src/__tests__/toThrowMatchers-test.js<dim>:24:74)</>"
`;

exports[`.toThrowError() promise/async throws if Error-like object is returned threw, but should not have 1`] = `
[Error: expect(received).rejects.not.toThrowError()
"<dim>expect(</><red>received</><dim>).</>rejects<dim>.</>not<dim>.</>toThrowError<dim>()</>

Received error name: "Error"
Received error message: "async apple"
Received error name: <red>\\"Error\\"</>
Received error message: <red>\\"async apple\\"</>

at jestExpect (packages/expect/src/__tests__/toThrowMatchers-test.js:24:74)]
<dim>at jestExpect (</>packages/expect/src/__tests__/toThrowMatchers-test.js<dim>:24:74)</>"
`;

exports[`.toThrowError() regexp did not throw at all 1`] = `
Expand Down
6 changes: 3 additions & 3 deletions packages/expect/src/__tests__/toThrowMatchers.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ class customError extends Error {
} catch (error) {
err = error;
}
expect(err).toMatchSnapshot();
expect(err && err.message).toMatchSnapshot();
});

test('threw, but class did not match', async () => {
Expand All @@ -215,7 +215,7 @@ class customError extends Error {
} catch (error) {
err = error;
}
expect(err).toMatchSnapshot();
expect(err && err.message).toMatchSnapshot();
});

test('threw, but should not have', async () => {
Expand All @@ -225,7 +225,7 @@ class customError extends Error {
} catch (error) {
err = error;
}
expect(err).toMatchSnapshot();
expect(err && err.message).toMatchSnapshot();
});
});

Expand Down