Issue4969: Standardize filenames: jest-runner pkg#7464
Conversation
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
mind updating the test_runner.test.js as well? :) and update the changelog? there's shared entry for standardizing filenames
|
@thymikee I wasn't sure how to update the CHANGELOG until after I had created the PR so that I'd have the PR # to add to the Changelog. So then I updated the Changelog on my local branch and pushed it up. Is that the correct process? Regarding |
|
Looks like you have older master locally. Can you rebase/merge with this repo master (test failures should be gone once you do it) and update the changelog accordingly? |
|
It looks like I successfully resolved the issue (sorry, my git foo is not yet strong). I'll move on to |
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Can you rebase and adjust changleog so it fits into generic point where we gather all file renames? It's tagged with [*]
Codecov Report
@@ Coverage Diff @@
## master #7464 +/- ##
=======================================
Coverage 67.15% 67.15%
=======================================
Files 247 247
Lines 9502 9502
Branches 5 5
=======================================
Hits 6381 6381
Misses 3119 3119
Partials 2 2
Continue to review full report at Codecov.
|
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Awesome! Thanks for cooperation 🙂
* master: (24 commits) Add `jest.isolateModules` for scoped module initialization (jestjs#6701) Migrate to Babel 7 (jestjs#7016) docs: changed "Great Scott!" link (jestjs#7524) Use reduce instead of filter+map in dependency_resolver (jestjs#7522) Update Configuration.md (jestjs#7455) Support dashed args (jestjs#7497) Allow % based configuration of max workers (jestjs#7494) chore: Standardize filenames: jest-runner pkg (jestjs#7464) allow `bail` setting to control when to bail out of a failing test run (jestjs#7335) Add issue template labels (jestjs#7470) chore: standardize filenames in e2e/babel-plugin-jest-hoist (jestjs#7467) Add node worker-thread support to jest-worker (jestjs#7408) Add `testPathIgnorePatterns` to CLI documentation (jestjs#7440) pretty-format: Omit non-enumerable symbol properties (jestjs#7448) Add Jest Architecture overview to docs. (jestjs#7449) chore: run appveyor tests on node 10 chore: fix failures e2e test for node 8 (jestjs#7446) chore: update docusaurus to v1.6.0 (jestjs#7445) Enhancement/expect-to-be-close-to-with-infinity (jestjs#7444) Update CHANGELOG formatting (jestjs#7429) ...
* renamed 'run_test.js' to 'runTest.js' and updated imports * renamed 'test_worker.js' to 'testWorker.js' and updated imports * added PR to CHANGELOG * renamed test_runner.test.js to testRunner.test.js * Consolidated this PR to generic point with other file renames
* renamed 'run_test.js' to 'runTest.js' and updated imports * renamed 'test_worker.js' to 'testWorker.js' and updated imports * added PR to CHANGELOG * renamed test_runner.test.js to testRunner.test.js * Consolidated this PR to generic point with other file renames
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Summary
This PR standardizes the filenames in the
jest-runnerpackage as specified in Issue #4969Test plan
No new test were written. Package passes existing tests.