Correct example usage of expect().rejects#7431
Conversation
I tried following the docs to learn how `expect().rejects` works, but I couldn't get my tests to pass. I then found https://jestjs.io/docs/en/tutorial-async#rejects and that got my tests to pass. This commit updates the docs to match.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
LGTM but would be good for @SimenB to take a look
|
Someone should definitely confirm - I've been using Jest all of 2 days! But the inconsistency caught my eye. |
|
Related: #4884 |
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
Just checked, the .toThrow version works for me
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Weird, I guess I'll have to chalk it up to me being new to Jest! Thanks for taking the time to check. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
I tried following the docs to learn how
expect().rejectsworks, but I couldn't get my tests to pass. I then found https://jestjs.io/docs/en/tutorial-async#rejects and that got my tests to pass. This PR updates the docs to match.Summary
Test plan