Fix Custom Matchers API example message property#7426
Conversation
message should return a function and not a constant
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
|
||
| ### Chore & Maintenance | ||
|
|
||
| - `[docs]` Fix message property in custom matcher example to return a function instead of a constant. |
* (fix) message should return a function message should return a function and not a constant * Update CHANGELOG.md
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
5 participants
Summary
The example for a custom matcher 'message' property returns a string, it should be a function.
Test plan
Types of property 'message' are incompatible. Type 'string' is not assignable to type '() => string'so updated accordingly