#7101 Not using collectCoverageFrom when in watch mode with test filtering

[duszans]

Summary

Fix for #7101

Test plan

1. Checked it solves the problem described in Watch mode filename/test name filtering is not taken into account for coverage calculation with collectCoverageFrom set #7101
2. Checked that also without watch and without collectCoverageFrom it still works correct

[rickhanlonii]

LGTM!

[rickhanlonii]

@duszans can you fix the conflict?

[SimenB]

@stipsan thoughts on this?

[rogeliog]

Could we add tests for this?

[rogeliog]

Should we also check for !config.watchAll?

[duszans]

@rogeliog I don't think so - the watchAll is true when all files are watched in watch mode.
watch is true when there is some filtering applied, e.g. by test file name (at least in jest-cli/src/watch.js)

[stipsan]

What will happen if you have negated patterns as well?

{
  "collectCoverageFrom": [
    "**/*.{js,jsx}",
    "!**/node_modules/**",
    "!**/vendor/**"
  ]
}

Will files from vendor suddenly show up? There is also another use case: —findRelatedTests. It uses collectCoverageFrom under the hood and it seems like this PR would break commands like: jest --watch --coverage —findRelatedTests file1.js?

A quick way to fix this could be to check for wether filename or testname filtering is applied in addition to the watch mode check in this PR.
A longer but perhaps safer fix could be to apply the filters on top of collectCoverageFrom instead of ignoring it, so that negative patterns are still in effect 🤔

[duszans]

@stipsan Could you provide reproduction steps for what could be broke in this PR related to --findRelatedTests? I checked that in my case it works fine with these changes.
In my sample repository which is mentioned in the related issue when I do with changes from this PR:

jest --watch --coverage --findRelatedTests src/add.js

then related add-test.js is run and coverage calculated only for add.js as expected.

[duszans]

@stipsan I also checked jest --watch --coverage with a file src/square.js which uses vendor/multiply.js, and a src/square-test.js and with the config you mentioned:

  "collectCoverageFrom": [
    "**/*.{js,jsx}",
    "!**/node_modules/**",
    "!**/vendor/**"
  ]

and with these changes it works just fine (e.g. it takes "!**/vendor/** into account). When filtering by square test file name no files from vendor are shown in the coverage. If I remove the vendor exclusion from collectCoverageFrom then vendor/multiply.js is taken into account so negations from collectCoverageFrom are clearly still working correctly.

[duszans]

Are there any other thoughts/issues to consider or can this be merged?

[codecov-io]

Codecov Report

Merging #7153 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7153   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files         248      248           
  Lines        9615     9615           
  Branches        3        4    +1     
=======================================
  Hits         6472     6472           
  Misses       3142     3142           
  Partials        1        1

Impacted Files	Coverage Δ
...ckages/jest-cli/src/reporters/coverage_reporter.js	67.71% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9fc73...ed4a1bf. Read the comment docs.

[rickhanlonii]

Did you see @rogeliog's comment about adding a test?

[stipsan]

@duszans Awesome, thanks for taking the time to check those use cases 👍😃

[SimenB]

@duszans mind adding a test so we can land this?

[SimenB]

Missing test

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.