-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
config#collectCoverageFrom #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "packages\/jest" | ||
| "collectCoverageFrom": [ | ||
| "*.js", | ||
| "!setup.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also can specify excludes. so the default should be something like
collectCoverageFrom = [
'**/*.js',
'!*__mocks__*',
'!*node_modules*',
];There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
|
This looks good! If we are doing a major version bump for this, should we completely remove coverageIgnorePatterns and collectCoverageOnlyFrom? I don't think these are important enough that we have to do two majors for deprecation + removal, so I'm ok with being radical. |
|
@cpojer i would rather keep it secret and undocumented for a while. I want to see how easy it is to use it and how it performs. I'm not really a fan of having both regexes and globs together :) |
|
Ok. |
c85ace6 to
aeae889
Compare
|
how is this going to work with scriptPreprocessors? I am using typescript and using a preprocessor for that. |
|
Also, when are you guys planning to document this? |
|
@faisalil it'll first run the files through your preprocessor and then through the coverage instrumenter. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.