refactor(jest-util): fix type errors in test files #13464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Oct 18, 2022
Comment on lines
-26
to
+28
| // @ts-expect-error | ||
| get foo() { | ||
| fn(); | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
TypeScript was insisting that a getter should return something.
| process.env.TERM = term; | ||
|
|
||
| const isInteractive = ( | ||
| require('../isInteractive') as typeof import('../isInteractive') |
Contributor
Author
There was a problem hiding this comment.
To avoid repeating this line, it made sense to employ each here.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is fixing type errors in test files of
jest-utilpackage.Test plan
Green CI.