-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feature: allow ESM for test environment #11033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4fd65cd
feature: use ESM for test environment
92ed5b5
chore: add entry for 11033
06ef9d3
Merge branch 'master' into feature/10018
6dac94a
fix: check for ESM error type
08dfd90
test: dummy test using dummy ESM test env
6fe357a
chore: add prepare to build
94ec8de
chore: cleanup prepare script
f0e03c1
fix: alphabetical order
e1e71d1
fix: test using a global var
bc05a50
fix: this package is a module
da49111
Merge branch 'master' into feature/10018
a4b00c2
fix: remove unused variables
4db7cfb
Merge branch 'master' into feature/10018
SimenB 2b1bff2
actually run the e2e test
SimenB 567de0d
fix test
SimenB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import {resolve} from 'path'; | ||
| import {onNodeVersions} from '@jest/test-utils'; | ||
| import runJest from '../runJest'; | ||
|
|
||
| // The versions where vm.Module exists and commonjs with "exports" is not broken | ||
| onNodeVersions('^12.16.0 || >=13.7.0', () => { | ||
| it('support test environment written in ESM', () => { | ||
| const DIR = resolve(__dirname, '../test-environment-esm'); | ||
| const {exitCode} = runJest(DIR); | ||
|
|
||
| expect(exitCode).toBe(0); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import NodeEnvironment from 'jest-environment-node'; | ||
|
|
||
| export default class Env extends NodeEnvironment { | ||
| constructor(...args) { | ||
| super(...args); | ||
| this.global.someVar = 42; | ||
| } | ||
| } | ||
11 changes: 11 additions & 0 deletions
11
e2e/test-environment-esm/__tests__/testUsingESMTestEnv.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
| 'use strict'; | ||
|
|
||
| test('dummy', () => { | ||
| expect(global.someVar).toBe(42); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "module", | ||
| "jest": { | ||
| "testEnvironment": "<rootDir>/EnvESM.js", | ||
| "transform": {} | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.