24.1.0: TypeError: Cannot read property 'cwd' of undefined

[SethDavenport]

🐛 Bug Report

I've updated one of my projects from babel 6 to babel 7. As part of this, I've also

• updated from Jest/Babel-Jest 23 to Jest/Babel-Jest 24.
• updated my custom JS transformer to use babel 7 stuff.

When I run my tests, I get the following error:

  ● Test suite failed to run

    TypeError: Cannot read property 'cwd' of undefined
      at Object.getCacheKey (node_modules/babel-jest/build/index.js:155:51)

I can "fix" this error and get my tests running again if I hack node_modules/babel-jest/build/index.js as follows:

    getCacheKey(
      fileData,
      filename,
      configString,
      {config, instrument, rootDir}
    ) {
      // ORIGINAL:
      // const babelOptions = loadBabelConfig(config.cwd, filename);
      // HACK:
      const babelOptions = loadBabelConfig(config ? config.cwd : rootDir, filename);

      // ...

With this, my tests run fine, however I don't really understand under what circumstances config could be undefined.

To Reproduce

Here are my configs:

package.json:

"jest": {
    "transform": {
      "^.+\\.js$": "<rootDir>/jest/js-loader.js",
      "^.+\\.html$": "<rootDir>/jest/html-loader.js"
    },
    "transformIgnorePatterns": [
      "/node_modules/(?!@wealthsimple)/"
    ],
    "globals": {
      "jasmine": {}
    },
    "setupFiles": [
      "<rootDir>/jest/setup.js"
    ],
    "testMatch": [
      "**/?(*.)+(jest).js?(x)"
    ],
    "modulePathIgnorePatterns": [
      "<rootDir>/.yarn-cache/"
    ],
    "collectCoverageFrom": [
      "src/**/*.js"
    ],
  },

jest/js-loader.js:

const config = {
  presets: [
    [
      '@babel/preset-env',
      {
        targets: {
          node: 'current',
        },
      },
    ],
    '@babel/react',
  ],
  plugins: [
    '@babel/plugin-transform-flow-strip-types',
    'dynamic-import-node',
    'styled-components',
    '@babel/plugin-transform-object-assign',
    '@babel/plugin-proposal-class-properties',
    '@babel/plugin-proposal-object-rest-spread',
    '@babel/plugin-transform-async-to-generator',
  ],
  sourceMaps: 'inline',
};

module.exports = require('babel-jest').createTransformer(config);

Expected behavior

Tests to run as they did with babel 6/babel-jest 23.

Run npx envinfo --preset jest

Paste the results here:

npx: installed 1 in 2.548s

  System:
    OS: macOS 10.14.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 10.12.0 - ~/.config/fnm/bin/node
    Yarn: 1.12.3 - /usr/local/bin/yarn
    npm: 6.4.1 - /usr/local/bin/npm
  npmPackages:
    jest: ^24.1.0 => 24.1.0

[jeysal]

Does the error still occur without the setupFiles?
@SimenB I think this might be allTests[0].context.config from #7562 again, only way I can think of that an undefined config could get into a transformer

[SimenB]

Might be. This needs a proper reproduction, though. @SethDavenport mind putting together a more complete project we can pull down and test? As minimal as possible, although it should be fairly easy to debug bigger projects here as well 🙂

If it's hard to isolate, you can change this to just be return lines; which should give a full stack trace including internals: https://github.com/facebook/jest/blob/9ba62ada66f731880229073eb193e8cb60863ae3/packages/jest-message-util/src/index.ts#L156

[SethDavenport]

@jeysal it still happens without the setupfile, yes.

[SethDavenport]

@SimenB it might be tricky to extract. I'll take a shot this evening. In the meantime the change you suggested to jest-message-util results in this:

 FAIL  src/app/common/services/account-summary/account-summary.service.jest.js
  ● Test suite failed to run

    TypeError: Cannot read property 'cwd' of undefined

      at Object.getCacheKey (node_modules/babel-jest/build/index.js:155:51)
      at ScriptTransformer._getCacheKey (node_modules/jest-runtime/build/script_transformer.js:159:23)
      at ScriptTransformer._getFileCachePath (node_modules/jest-runtime/build/script_transformer.js:185:27)
      at ScriptTransformer.transformSource (node_modules/jest-runtime/build/script_transformer.js:279:32)
      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:388:40)
      at ScriptTransformer.transform (node_modules/jest-runtime/build/script_transformer.js:448:19)
      at Runtime._execModule (node_modules/jest-runtime/build/index.js:640:53)
      at Runtime.requireModule (node_modules/jest-runtime/build/index.js:376:14)
      at new Runtime (node_modules/jest-runtime/build/index.js:219:14)
      at node_modules/jest-runner/build/run_test.js:98:15

[Oliphaunte]

I can confirm the same issue occurring for me in a starter react-setup package I am working on, which is hopefully simple enough to allow for debugging.

https://github.com/Oliphaunte/react_redux_setup

I can also confirm the updates @SethDavenport made in node_modules/babel-jest/build/index.js fixed the issue for me, yarn test runs successfully post-edits. However, it only seems to work with a .babelrc.js object configuration. It still does not work with a babel.config.js setup, not sure if that's just me though, would love to find out any additional information on that front as well.

[debuggy]

Same bug occured in my project. For the detailed info:

 FAIL  tests/schema-validator.test.js
  ● Test suite failed to run

    TypeError: Cannot read property 'cwd' of undefined

      at Object.getCacheKey (node_modules/babel-jest/build/index.js:155:51)

[moafzalmulla]

Same thing on mine :

TypeError: Cannot read property 'cwd' of undefined
      
      at Object.getCacheKey (node_modules/babel-jest/build/index.js:155:51)

I am testing the header.js component, and my test resides in header.test.js :

import React from "react";
import renderer from "react-test-renderer";

import Header from "./header";

describe("Header", () => {
  it("renders correctly", () => {
    const tree = renderer
      .create(<Header siteTitle="Gatsby Jest Test" />)
      .toJSON()
    expect(tree).toMatchSnapshot()
  })
})

Any ideas what could be wrong?

[SethDavenport]

Thanks for making a repro repo @Oliphaunte - oddly my attempt to do so didn't reproduce the issue so I'm no closer to understanding what about my environment is triggering it.

I did come up with a slightly better workaround than editing my node_modules:

const c = {
  presets: [
    '@babel/preset-env',
    '@babel/react',
  ],
  plugins: [
    '@babel/plugin-transform-flow-strip-types',
    'dynamic-import-node',
    'styled-components',
    '@babel/plugin-transform-object-assign',
    '@babel/plugin-proposal-class-properties',
    '@babel/plugin-proposal-object-rest-spread',
    '@babel/plugin-transform-async-to-generator',
  ],
  sourceMaps: 'inline',
};

const defaultCwd = process.cwd();
const transformer = require('babel-jest').createTransformer(c);

// Monkey patch around https://github.com/facebook/jest/issues/7868
const oldGetCacheKey = transformer.getCacheKey;
transformer.getCacheKey = (
  fileData,
  filename,
  configString,
  { config, instrument, rootDir },
) =>
  oldGetCacheKey(
    fileData,
    filename,
    configString, {
      config: config || { cwd: defaultCwd },
      instrument,
      rootDir,
    },
  );

module.exports = transformer;

[SimenB]

@Oliphaunte your reproduction uses jest@23 with babel-jest@24 - that's not supported. Upgrading to jest@24 makes your test pass.

I wonder if we should have a peer dep?

[SimenB]

@SethDavenport Can you verify the version of jest-runtime in your repo?

[Oliphaunte]

@SimenB That was a careless mistake on my part, I updated all my packages incorrectly before running those tests. It all works correctly now with the latest versions. I've also updated the package I shared previously in case anybody needs more reference.

Thank you @SimenB for your help!

[SethDavenport]

@SimenB I am not explicitly pulling in jest-runtime in my package.json. Should I be?

My yarn.lock has both 23.6.0 and 24.1.0 of jest-runtime, likely due to a downstream dependency using jest 23.