fix(matchers): avoid TypeError in toContainAllKeys when received is nullish#935
Open
greymoth-jp wants to merge 1 commit into
Open
fix(matchers): avoid TypeError in toContainAllKeys when received is nullish#935greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
…ullish Object.keys(actual) was called unconditionally when building the failure message, throwing TypeError for null/undefined instead of a clean assertion message. Print the raw received value for nullish input, matching toContainKey (made null-safe in jest-community#878).
🦋 Changeset detectedLatest commit: cd042f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toContainAllKeysbuilds its failure message fromObject.keys(actual), called unconditionally in both branches. When the received value isnullorundefinedthis throwsTypeError: Cannot convert undefined or null to object, so you get an unrelated crash instead of a normal assertion failure:The
passresult itself is already null-safe (it is guarded bytypeof actual === 'object' && actual !== null); only the message builder is affected.The sibling key matchers
toContainKey,toContainKeysandtoContainAnyKeyswere made null-safe in #878 and print the received value directly. This does the same fortoContainAllKeys: the message prints the raw value fornull/undefined(matchingtoContainKey's output) and is unchanged for every other input.The existing test already called
expect(null).toContainAllKeys(['a', 'b'])under "fails when actual is not an object", but its snapshot had captured theTypeErrortext rather than an assertion message. The snapshot is updated and anundefinedcase is added to match the sibling tests.