Add framecraft demo video generator plugin#506
Merged
jeremylongshore merged 4 commits intojeremylongshore:mainfrom Apr 7, 2026
Merged
Add framecraft demo video generator plugin#506jeremylongshore merged 4 commits intojeremylongshore:mainfrom
jeremylongshore merged 4 commits intojeremylongshore:mainfrom
Conversation
Review Summary by QodoAdd framecraft demo video generator plugin
WalkthroughsDescription• Adds framecraft plugin for generating polished demo videos • Includes plugin metadata, skill definition, and documentation • Registers plugin in both marketplace.json and marketplace.extended.json • Supports Playwright, FFmpeg, and Edge TTS MCP server orchestration Diagramflowchart LR
A["framecraft Plugin"] --> B["plugin.json"]
A --> C["SKILL.md"]
A --> D["README.md"]
B --> E["marketplace.json"]
B --> F["marketplace.extended.json"]
C --> G["Demo Video Generation"]
G --> H["Playwright + FFmpeg + Edge TTS"]
File Changes1. plugins/community/framecraft/.claude-plugin/plugin.json
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+1
to
+20
| { | ||
| "name": "framecraft", | ||
| "version": "1.0.0", | ||
| "description": "Generate polished demo videos from a single prompt. Orchestrates Playwright, FFmpeg, and Edge TTS MCP servers to produce 1920x1080 videos with voiceover, transitions, and CSS animations.", | ||
| "author": { | ||
| "name": "vaddisrinivas", | ||
| "url": "https://github.com/vaddisrinivas" | ||
| }, | ||
| "repository": "https://github.com/vaddisrinivas/framecraft", | ||
| "license": "MIT", | ||
| "keywords": [ | ||
| "demo-video", | ||
| "video-generation", | ||
| "playwright", | ||
| "ffmpeg", | ||
| "edge-tts", | ||
| "mcp", | ||
| "agent-skills" | ||
| ] | ||
| } |
There was a problem hiding this comment.
4. Plugin license file missing 🐞 Bug ☼ Reliability
The new plugin at plugins/community/framecraft is missing a root LICENSE file, but the repository plugin validator requires LICENSE for every plugin and will fail validation.
Agent Prompt
## Issue description
The new plugin `plugins/community/framecraft` is missing a `LICENSE` file, which is required by the repo's plugin validator.
## Issue Context
The validator checks for `README.md`, `LICENSE`, and `.claude-plugin/plugin.json` in every plugin directory.
## Fix Focus Areas
- scripts/validate-plugin.js[509-514]
- plugins/community/framecraft/.claude-plugin/plugin.json[1-20]
## Suggested fix
1. Add `plugins/community/framecraft/LICENSE` containing the MIT License text.
2. Ensure the copyright line is set appropriately (year + author/organization).
3. (Optional) Add a short "License" section in `plugins/community/framecraft/README.md` pointing to the local `LICENSE` file, not only an external link.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Contributor
Author
|
All issues from the initial review have been addressed in commit 59fe66f:
|
Owner
jeremylongshore
left a comment
jeremylongshore
left a comment
There was a problem hiding this comment.
Framecraft Review
Good submission — structurally clean, skill content is substantive. Three items to fix:
Must Fix
-
Update PR description — Remove the claim about editing
marketplace.json. That file is auto-generated. Confirmpnpm run sync-marketplacewas run after editingmarketplace.extended.json. -
Unscoped
Bashinallowed-tools— CurrentlyBashwith no restriction. Since the skill runsuv,ffmpeg, andplaywright, document in the README why broad shell access is needed. Ideally scope toBash(uv:*), Bash(ffmpeg:*)if the validator accepts it. -
README install instructions — Currently shows
claude plugin install framecraftbut the correct pattern is:claude plugin marketplace add jeremylongshore/claude-code-pluginsThen
ccpi install framecraftor via the marketplace. Match the repo's canonical install pattern.
Nice to Have
- Author format in SKILL.md —
vaddisrinivas <url>is unconventional. Standard isName <email>. - Document Edge TTS network dependency and fallback behavior.
Everything else passes: plugin.json fields are clean, LICENSE present, SKILL.md has all required frontmatter, content is substantive with good error handling table and examples.
- Revert hand-edited marketplace.json (auto-generated, kept extended.json) - Fix allowed-tools: use valid tool names (Bash not Bash(uv:*)) - Add required sections: Instructions, Error Handling, Examples, Resources - Add MIT LICENSE file to plugin directory - Fix install docs to use marketplace slug (@claude-code-plugins-plus) - Use full edge-tts voice names (en-US-AndrewNeural) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
**Must-fix items:** - Update author format to standard 'Name <email>' in plugin.json and SKILL.md - Fix README install instructions (correct repo path: jeremylongshore/claude-code-plugins) - Add Permissions section documenting why scoped Bash access is needed **Network dependency:** - Document Edge TTS requires internet connectivity (no offline fallback) **Details:** - Author now: 'Srinivas Vaddisrinivas <vaddisrinivas@gmail.com>' - Install path: 'claude plugin marketplace add jeremylongshore/claude-code-plugins' - Permissions: Bash scopes documented (uv, ffmpeg, python) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
vaddisrinivas
force-pushed
the
add-framecraft
branch
from
7e8ce19 to
74734ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the framecraft plugin to
plugins/community/.What it does: Generate polished demo videos from a single prompt. Orchestrates Playwright, FFmpeg, and Edge TTS MCP servers to produce 1920x1080 videos with voiceover, transitions, and CSS animations.
Source repo: https://github.com/vaddisrinivas/framecraft
Includes:
plugin.jsonwith required metadata fieldsskills/demo-video/SKILL.mdwith 2026 schema frontmatterREADME.mdmarketplace.jsonandmarketplace.extended.jsonInstall:
claude plugin install framecraftornpx skills add vaddisrinivas/framecraftMIT licensed.