Conversation
|
@jeremyevans please have a look if this is the direction you were intending. I haven't quite finished looking over all the template docs, but I would ultimately like to move everything out of I'll squash everything into a single commit unless you want small granular commits? |
|
In particular, I'm not sure where/how to split the different ERB template documentations. Are there two implementations in the standard library ( |
|
Thank you very much for working on this. For erb, have the general documentation in the erubi.rb template file as it is the default, with only |
|
I'm done with the initial move - could you please check the assignment for the ERB and Markdown templates in particular? |
|
@jeremyevans If you have changes that need to go into this PR, please feel free to commit to this branch |
|
This looks great, thank you! A few minor things I noticed:
|
|
Thanks for your guidance, a pleasure to help. I have integrated these changes - one question about the related modules remains in my mind: For classes, which are defined in the following manner, the RDoc refernences work fine: module Tilt
class ERBTemplate < Template
# ...
end
endFor classes, which assign a constant via Tilt::SlimTemplate = Slim::TemplateSee How would you like me to proceed with these? |
I think we should not include the Thank you again for working on this. After the removal of the |
79ab02f to
896bbde
Compare
|
Looks good to me, go ahead at your discretion! |
The main template table in README.md links to these via rdoc-ref. Remove TEMPLATES.md and convert docs from markdown to rdoc syntax.
896bbde to
10ee4b5
Compare
|
Merged at e109816. Will work on the website tomorrow. Thank you again for your patience and work in getting these changes prepared. |
|
Website now up: https://tilt.jeremyevans.net/ |
Move the template descriptions into their
./lib/tilt/*.rbfiles and link to these from the README