Make the rendering of Prawn templates idempotent#20
Merged
jeremyevans merged 1 commit intojeremyevans:masterfrom Jul 13, 2025
Merged
Make the rendering of Prawn templates idempotent#20jeremyevans merged 1 commit intojeremyevans:masterfrom
jeremyevans merged 1 commit intojeremyevans:masterfrom
Conversation
Owner
|
Thank you for the patch. Looks like this issue has been present ever since the code was initially added in e859993. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when I reuse a Prawn template to render a PDF, instead of getting a pristine output, it would render the new PDF on top of the previous one. Because the
Prawn::Documentdoes not get reset after rendering, it turns into palimpsest.This change ensures that every render starts with a fresh
Prawn::Documentto avoid this behavior.