Skip to content

Conversation

@jasondamour
Copy link

…ther applications. I would love help testing and completing, are advice from previous contributors. This is my first Jenkins contribution :)

@GLundh
Copy link
Member

GLundh commented Jan 18, 2018

I'll try to free some time tomorrow to review this. Thanks for the contribution!

return;
}
project.checkPermission(Item.BUILD);
if (isRebuildAvailable()) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what i understand, this is the key area that needs to change. Ideally, we can just skip the step where collect the user input through the form. I think what I have here will still throw exceptions because it tries to parse a form that may not be collected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that the best (and easiest way) would be to serialize all source build's ParametersActions and then deserialize them to essentially achieve a deep copy. Re-add them when scheduling the new build.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give me a little more detail please? Do you mean serializing and deserializing immediately? Is there somewhere in the existing code to look at?

@jasondamour
Copy link
Author

jasondamour commented Jan 26, 2018

Hello GLundh,

I've been reviewing my user story more, and I don't think it warrants this pull request after all. Does the rebuild plugin have any way of triggering a parameterized build other than the GUI? I'm trying to understand the code, does it accept post forms?

@jasondamour
Copy link
Author

jasondamour commented Feb 7, 2018

I cannot edit any files without the plugin crashing. Can you point me towards how you package the plugin?

Feb 07, 2018 11:56:57 AM hudson.ExpressionFactory2$JexlExpression evaluate
WARNING: Caught exception evaluating: it.upstreamUrl!=null and app.getItemByFullName(it.upstreamProject)!=null and app.getItemByFullName(it.upstreamProject).getBuildByNumber(it.upstreamBuild)!=null ? it.shortDescritptionHTML : it.shortDescription. Reason: java.lang.reflect.InvocationTargetException
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.commons.jexl.util.PropertyExecutor.execute(PropertyExecutor.java:125)
at org.apache.commons.jexl.util.introspection.UberspectImpl$VelGetterImpl.invoke(UberspectImpl.java:314)
at org.apache.commons.jexl.parser.ASTArrayAccess.evaluateExpr(ASTArrayAccess.java:185)
at org.apache.commons.jexl.parser.ASTIdentifier.execute(ASTIdentifier.java:75)
at org.apache.commons.jexl.parser.ASTReference.execute(ASTReference.java:83)
at org.apache.commons.jexl.parser.ASTReference.value(ASTReference.java:57)
at org.apache.commons.jexl.parser.ASTExpression.value(ASTExpression.java:54)
at org.apache.commons.jexl.parser.ASTTernaryNode.value(ASTTernaryNode.java:41)
at org.apache.commons.jexl.parser.ASTExpression.value(ASTExpression.java:54)
.
.
.
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:209)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:357)
at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:329)
at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:475)
Caused by: java.lang.Error: Unresolved compilation problem:
Messages cannot be resolved

at com.sonyericsson.rebuild.RebuildCause.getShortDescritptionHTML(RebuildCause.java:61)
... 131 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants