Skip to content

Conversation

@GLundh
Copy link
Member

@GLundh GLundh commented Aug 31, 2017

This PR ensures that also inherited parameters are added to the retriggered builds. I.e. parameters passed from the Parameterized Trigger Plugin.

We have been running this in production for over 1.5 years.

@hagzag: No commits have been merged to master for over 2 years. Let me know if you have time to look at this PR. If not, let me know if it is NOT OK to go ahead and merge this by myself.

Change-Id: I29000d58a94fa836d0bb2c1dd3d9e06d5e668383
Change-Id: I3e3c5c0426736b5b80c48c20fab69f46d6e80257
@GLundh GLundh requested a review from hagzag August 31, 2017 12:15
@GLundh
Copy link
Member Author

GLundh commented Sep 1, 2017

@rsandell How do you generally handle abandoned plugins? No new commits for over 2 years. Am I free to merge & release if the last active maintainer does not reply?

@rsandell
Copy link
Member

rsandell commented Sep 3, 2017

@GLundh normal procedure is to send a mail to the dev list and cc the maintainer.
If no response from the maintainer within 2 weeks we normally consider the plugin abandoned and allow you to merge. Normally also a plea for you to become the active maintainer as a response to your mail ;)

@GLundh
Copy link
Member Author

GLundh commented Sep 4, 2017

Thanks. I got hold of Ragesh over linkedin and he gave the "go ahead" with this and other PRs. Not sure if we want to pickup full "maintainership" of this plugin. Will talk to our team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants