JENKINS-38635: Correct NodeParameterValue.jelly #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixed the issue for me too. |
Author
|
FYI, looks like the CloudBees' Jenkins job failed because the POM is still referencing old URLs. Looks like this works but is VERY slow, not sure what the maintainers want to do about that or if they want to leave it as is, but this change definitely works. |
Member
|
Please rebase from master. The repository URLs have been updated. |
Member
|
I have verified locally. This seems to work fine. I'm merging and closing this one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes JENKINS-38635 "NodeLabelParameter empty on rebuild of job initiated by Startup Trigger"
I've been unable to find any use cases that are broken by it.