[SECURITY-2290] check permission as well #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Lamy <[email protected]>
olamy
force-pushed
the
SECURITY-2290-2
branch
from
40af73c to
c2e5ad9
Compare
Kevin-CB
reviewed
Feb 21, 2022
...main/java/jenkins/plugins/publish_over_ssh/descriptor/BapSshHostConfigurationDescriptor.java
Outdated
Show resolved
Hide resolved
Kevin-CB
reviewed
Feb 21, 2022
src/main/java/jenkins/plugins/publish_over_ssh/descriptor/BapSshPublisherPluginDescriptor.java
Outdated
Show resolved
Hide resolved
Kevin-CB
approved these changes
Feb 21, 2022
Contributor
Kevin-CB
left a comment
Kevin-CB
left a comment
There was a problem hiding this comment.
I tested this fix locally, the vulnerability is no longer present, however it is necessary to correct the 2 small copy paste typo.
Member
Author
|
oops my bad typo. good catch! |
…shPublisherPluginDescriptor.java Co-authored-by: Kevin Guerroudj <[email protected]>
…shHostConfigurationDescriptor.java Co-authored-by: Kevin Guerroudj <[email protected]>
daniel-beck
reviewed
Feb 21, 2022
| return FormValidation.validateNonNegativeInteger(value); | ||
| } | ||
|
|
||
| @RequirePOST |
Member
There was a problem hiding this comment.
No side effects, so not strictly necessary, but doesn't hurt either assuming the UI controls send POST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy [email protected]