Skip to content

Make CredentialsBindingContext extensible #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Make CredentialsBindingContext extensible #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...ore/src/main/groovy/javaposse/jobdsl/dsl/helpers/wrapper/CredentialsBindingContext.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
package javaposse.jobdsl.dsl.helpers.wrapper

import javaposse.jobdsl.dsl.AbstractContext
import javaposse.jobdsl.dsl.AbstractExtensibleContext
import javaposse.jobdsl.dsl.ContextType
import javaposse.jobdsl.dsl.Item
import javaposse.jobdsl.dsl.JobManagement
import javaposse.jobdsl.dsl.RequiresPlugin

class CredentialsBindingContext extends AbstractContext {
@ContextType('org.jenkinsci.plugins.credentialsbinding.MultiBinding')
class CredentialsBindingContext extends AbstractExtensibleContext {
final List<Node> nodes = []

CredentialsBindingContext(JobManagement jobManagement) {
super(jobManagement)
CredentialsBindingContext(JobManagement jobManagement, Item item) {
super(jobManagement, item)
}

/**
Expand Down Expand Up @@ -59,4 +62,9 @@ class CredentialsBindingContext extends AbstractContext {
credentialsId(credentials)
}
}

@Override
protected void addExtensionNode(Node node) {
nodes << node
}
}
2 changes: 1 addition & 1 deletion job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/wrapper/WrapperContext.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ class WrapperContext extends AbstractExtensibleContext {
*/
@RequiresPlugin(id = 'credentials-binding')
void credentialsBinding(@DslContext(CredentialsBindingContext) Closure closure) {
CredentialsBindingContext context = new CredentialsBindingContext(jobManagement)
CredentialsBindingContext context = new CredentialsBindingContext(jobManagement, item)
ContextHelper.executeInContext(closure, context)

wrapperNodes << new NodeBuilder().'org.jenkinsci.plugins.credentialsbinding.impl.SecretBuildWrapper' {
Expand Down