added embedded API Viewer #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I had to add
response.setContentType('application/javascript')here to get this to work. I was getting:
Refused to execute script from 'http://localhost:8080/plugin/job-dsl/api-viewer/build/data/update-center.jsonp' because its MIME type ('') is not executable, and strict MIME type checking is enabled.
There was a problem hiding this comment.
Thanks for the hint. I want to get rid of the JSONP stuff. Maybe the JSONP can be processed in Gradle or Grunt to remove the padding. But that's another PR.
|
Very cool! |
|
@sheehan yes it is! Thanks to your single page app design! I did not expect that it will be so easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.