Added index check for the "default" IP #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check to make sure that the default IP exists in the container to make sure that the return is non-null
christ66
reviewed
Mar 24, 2017
| String route = out.toString("UTF-8").trim(); | ||
|
|
||
| // ensures that the the default IP exists so that the return is not null | ||
| if (route.indexOf("default") == -1){ |
Member
There was a problem hiding this comment.
Would be better to do:
if (!route.contains("default")) {
.....
Author
There was a problem hiding this comment.
You are right here, it is more precise and will probably work faster(maybe?).
Change is done
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
stephenc
approved these changes
Jun 2, 2017
oleg-nenashev
approved these changes
Jun 2, 2017
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
I would prefer a non-Runtime exception, but there is already a runtime one above in the code => the code does not get worse.
🐝
Member
|
@reviewbybees done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to make sure that the default IP exists in the container
to make sure that the return is non-null
@reviewbybees