remove unnecessary spam from the docker exec command line #51
Conversation
Variable definitions passed into docker run via --env are also included in the environment of commands launched via docker exec. So for every variable that matches the origin docker run environment, we can exclude that value from the command line and prevent unnecessary value spam in the build log as a bonus.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
As commands are launched in the container, we need to ensure that the environment passed in is as resolved as possible as further resolution isn't necessarily going to be done later.
|
Any progress on this one? We really need this one to work... |
|
Is there anything I can do to move this PR along? This change has been working well in our internal Jenkins environment for nearly 2 years now. |
|
This feature is very important and useful, please merge the PR. |
|
@jsu I'm just getting up to speed on this project. I will need some time to take a look. I need to test the changes locally, create a Maven release, update the changelog. If you (or anyone else) would like to add a functional test around this new behavior, patches are more than welcome! |
|
I have problem to compile the source code with the NoSuchFileException for Hudson.Extension. |
4 participants
Variable definitions passed into docker run via --env are also included
in the environment of commands launched via docker exec. So for every
variable that matches the origin docker run environment, we can exclude
that value from the command line and prevent unnecessary value spam in
the build log as a bonus.