[JENKINS-28399] Add binding for SSH private keys #18

matthauck · 2016-06-24T20:16:40Z

JENKINS-28399

matthauck · 2016-08-01T18:15:19Z

ping. Any chance this might get merged in?

matthauck · 2016-08-31T23:07:40Z

Hello? Is this plugin still active?

afalko · 2016-09-29T17:19:51Z

Not sure how to vote this one up, but we'd love to have this as well.

jglick · 2016-10-11T00:24:36Z

I will take a look when I have a moment.

jglick · 2016-10-11T00:27:36Z

JENKINS-28399 I suppose. Note that the usual alternative is to use the SSH Agent plugin so that the key is not actually used directly.

thomasgl-orange · 2016-10-11T07:36:56Z

Maybe this could/should be implemented in the jenkinsci/ssh-credentials-plugin instead? From discussion in #22, my understanding was that it would be better to implement new bindings directly in the plugins which provide the credentials types, inverting the dependency (that's what I ended up proposing in jenkinsci/docker-commons-plugin#54 for Docker client certificates).
@jglick: could you confirm/infirm?

matthauck · 2016-10-11T20:12:56Z

fwiw, I did not want to use the ssh agent plugin because of its extra installation burden (dependency on tomcat native libraries and needing to install BouncyCastle as a security provider). Having direct access to the key turned out to be easier.

Not sure about where this should live. Seems like putting the ssh key binding into the "binding" plugin seemed like the best place to me. I'll leave that decision up to the maintainer as to where it should live.

jglick · 2016-10-11T21:21:53Z

Maybe this could/should be implemented in the jenkinsci/ssh-credentials-plugin instead?

No strong preference I guess. Generally “domain-specific” bindings should live in the plugin defining that Credentials type. OTOH SSH credentials are very widely used and considered close to fundamental.

JENKINS-19508 is really the right solution IMO, but that is not available now.

@stephenc any particular opinion?

jglick · 2016-10-11T21:23:42Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+            return new FilePath(workspace.getChannel(), workspace.act(new FilePath.FileCallable<String>() {
+                @Override
+                public String invoke(File dir, VirtualChannel channel) throws IOException, InterruptedException {
+                    File f = File.createTempFile(prefix, suffix);


This will not work with Image.inside from docker-workflow. It is necessary to use the standard “temp workspace”. See FileBinding and #25.

jglick · 2016-10-11T21:24:14Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+
+                @Override
+                public void checkRoles(RoleChecker checker) throws SecurityException {
+                    // no op


No. Extend MasterToSlaveFileCallable instead.

jglick · 2016-10-11T21:24:31Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+    }
+
+    @Override public Set<String> variables() {
+        return new HashSet<String>(Arrays.asList(keyFileVariable, usernameVariable, passphraseVariable));


tip: ImmutableSet.of

jglick · 2016-10-11T21:25:08Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+        }
+
+        @Override public void unbind(Run<?, ?> build, FilePath workspace, Launcher launcher, TaskListener listener) throws IOException, InterruptedException {
+            new FilePath(workspace.getChannel(), this.filePath).delete();


workspace.child(filePath)

jglick · 2016-10-11T21:26:58Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+    @Rule public RestartableJenkinsRule story = new RestartableJenkinsRule();
+    @Rule public TemporaryFolder tmp = new TemporaryFolder();
+
+    private static class DummyPrivateKey extends BaseCredentials implements SSHUserPrivateKey, Serializable {


Should be unnecessary; use a normal BasicSSHUserPrivateKey.

Was going to do that originally but got hung on all the other stuff necessary to construct one (like PrivateKeySource), and seemed easier to just create a simple implementation of the interface here. Are you okay maybe with leaving this as is?

Up to you. BasicSSHUserPrivateKey would probably be easier.

would prefer to keep as-is if it's okay with you.

jglick · 2016-10-11T21:27:21Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+
+    @Test public void configRoundTrip() throws Exception {
+        story.addStep(new Statement() {
+            @SuppressWarnings("rawtypes")


Collections.<TheType>singletonList

jglick · 2016-10-11T21:28:50Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+                WorkflowRun b = p.getBuildByNumber(1);
+                assertNotNull(b);
+                SemaphoreStep.success("basics/1", null);
+                while (b.isBuilding()) { // TODO 1.607+ use waitForCompletion


Use story.j.waitForCompletion. Jenkins dependency irrelevant.

naphthalene · 2017-03-01T17:07:11Z

Is this dead in the water? I'm trying to figure out how to inject SSH creds into a kubernetes jnlp slave. I think I'm stuck with using a custom image with a key baked in.

matthauck · 2017-03-01T17:53:04Z

Sorry, by the time the review came in I had ditched this workflow for something else and have been distracted since. I can get this back up to date and address the review feedback.

naphthalene · 2017-03-01T21:40:34Z

No problem! I've got a workaround going.

matthauck · 2017-03-02T01:06:10Z

just rebased from master. will update per review feedback.

stephenc · 2017-03-02T20:27:10Z

@jglick I think this plugin is the correct place given that JENKINS-19508 has not been implemented (ssh-credentials being slightly more generic than this)

jglick · 2017-03-23T22:04:46Z

pom.xml

+    <dependency>
+      <groupId>org.jenkins-ci.plugins</groupId>
+      <artifactId>ssh-credentials</artifactId>
+      <version>1.11</version>


I would just make it a mandatory dep, as we do for plain-credentials: ssh-credentials does no harm if unused.

okay. was trying to be less aggressive here. can change this if you like.

jglick · 2017-03-23T22:04:56Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+/*
+ * The MIT License
+ *
+ * Copyright 2013 jglick.


Really? :-)

jglick · 2017-03-23T22:14:52Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+
+    @Override public MultiEnvironment bind(Run<?,?> build, FilePath workspace, Launcher launcher, TaskListener listener) throws IOException, InterruptedException {
+        SSHUserPrivateKey sshKey = getCredentials(build);
+        FilePath keyFile =  tempDir(workspace).child("ssh-key-" + keyFileVariable);


Better to use the new API in #25 when ready.

i see you reverted that PR. Do you want to wait until that api is ready?

Okay. Please ping me then when it is ready and I can update this PR.

jglick · 2017-03-23T22:16:32Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+    public final String usernameVariable;
+    public final String passphraseVariable;
+
+    @DataBoundConstructor public SSHUserPrivateKeyBinding(String keyFileVariable, String passphraseVariable, String usernameVariable, String credentialsId) {


Since passphraseVariable and usernameVariable are not necessarily required, better to make these @CheckForNull properties with @DataBoundSetter.

jglick · 2017-03-23T22:22:25Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+/*
+ * The MIT License
+ *
+ * Copyright 2015 Jesse Glick.


hah. was copy-pasting from other tests probably. i'll take that out.

Can I just leave out this copyright?

jglick · 2017-03-23T22:23:07Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+                WorkflowJob p = story.j.jenkins.createProject(WorkflowJob.class, "p");
+                p.setDefinition(new CpsFlowDefinition(""
+                        + "node {\n"
+                        + "  withCredentials([[$class: 'SSHUserPrivateKeyBinding', keyFileVariable: 'THEKEY', passphraseVariable: 'THEPASS', usernameVariable: 'THEUSER', credentialsId: '" + credentialsId + "']]) {\n"


Add a @Symbol.

jglick · 2017-03-23T22:23:45Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+    @Rule public RestartableJenkinsRule story = new RestartableJenkinsRule();
+    @Rule public TemporaryFolder tmp = new TemporaryFolder();
+
+    private static class DummyPrivateKey extends BaseCredentials implements SSHUserPrivateKey, Serializable {


Up to you. BasicSSHUserPrivateKey would probably be easier.

tutipeti · 2017-04-19T08:51:06Z

Hey, any chance to merge this soon? Would be much appreciated :)

matthauck · 2017-04-19T16:55:05Z

It's already been another month since #25 was opened and closed. Not seeing any open PRs on that either. It seems strange to me to hold up this PR (which other people than myself clearly have interest in) for a new API that isn't there yet, and it is a little frustrating how long this PR has dragged on.

If you guys think this is a worthwhile feature to add, and if the current implementation here is correct, then why not just merge in this PR now and change to use the new API when it is done?

jglick · 2017-06-13T17:57:00Z

#36 now.

jglick · 2017-06-21T14:53:52Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+    }
+
+    @DataBoundSetter
+    @CheckForNull


This annotation is meaningless on a method returning void! Did you mean to place it on the getter?

jglick · 2017-06-21T14:53:58Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+    }
+
+    @DataBoundSetter
+    @CheckForNull


jglick · 2017-06-21T14:55:53Z

src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding.java

+        UnbindableDir keyDir = UnbindableDir.create(workspace);
+        FilePath keyFile =  keyDir.getDirPath().child("ssh-key-" + keyFileVariable);
+
+        StringWriter stringWriter = new StringWriter();


Simpler to use FilePath.write().

jglick · 2017-06-21T14:58:11Z

...n/resources/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyBinding/help.html

@@ -0,0 +1,9 @@
+<div>
+    Copies the SSH key file given in the credentials to a temporary location, then sets a variable to that location.
+    (The file is deleted when the build completes.) Also sets variables for the SSH key's username and passphrase.


Nice to create help-passphraseVariable.html giving specifics, such as that two parameters are optional. Can also add doCheck* methods to the descriptor guiding the user to fill in keyFileVariable but allowing the others to remain blank.

jglick · 2017-06-22T17:22:29Z

After I get #42 to pass and merge it, you will need to merge with master to resolve conflicts and get the new CI builder running the tests on both Linux and Windows.

jglick · 2017-06-23T19:19:24Z

Done, please merge.

naphthalene · 2017-06-23T19:54:18Z

Thank you for pushing this through!!

jglick

Some test failures caught by CI.

jglick · 2017-06-26T21:42:28Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+                        + "node {\n"
+                        + "  withCredentials([sshUserPrivateKey(keyFileVariable: 'THEKEY', passphraseVariable: 'THEPASS', usernameVariable: 'THEUSER', credentialsId: '" + credentialsId + "')]) {\n"
+                        + "    semaphore 'basics'\n"
+                        + "    sh '''\n"


fails on Windows

jglick · 2017-06-26T21:42:47Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+                        + "node {\n"
+                        + "  withCredentials([sshUserPrivateKey(keyFileVariable: 'THEKEY', credentialsId: '" + credentialsId + "')]) {\n"
+                        + "    semaphore 'basics'\n"
+                        + "    sh '''\n"


fails on Windows

jglick · 2017-06-26T21:43:14Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+                p.setDefinition(new CpsFlowDefinition(""
+                        + "node {\n"
+                        + "  withCredentials([sshUserPrivateKey(keyFileVariable: 'THEKEY', credentialsId: '" + credentialsId + "')]) {\n"
+                        + "    semaphore 'basics'\n"


Misleading semaphore name BTW; could use a more generic name (they are not shared between tests).

jglick · 2017-06-26T21:43:32Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+                        + "  withCredentials([sshUserPrivateKey(keyFileVariable: 'THEKEY', credentialsId: '" + credentialsId + "')]) {\n"
+                        + "    semaphore 'basics'\n"
+                        + "    sh '''\n"
+                        + "      set +x\n"


not actually necessary

jglick · 2017-06-26T21:43:44Z

src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java

+                        + "  withCredentials([sshUserPrivateKey(keyFileVariable: 'THEKEY', passphraseVariable: 'THEPASS', usernameVariable: 'THEUSER', credentialsId: '" + credentialsId + "')]) {\n"
+                        + "    semaphore 'basics'\n"
+                        + "    sh '''\n"
+                        + "      set +x\n"


not actually necessary

matthauck · 2017-06-26T21:51:20Z

yeah, the test were written originally w/ only linux in mind....

jglick · 2017-06-30T16:12:57Z

Need to either update them to run on Windows, or at a minimum

assumeFalse(Functions.isWindows()); // TODO provide a Windows equivalent

matthauck · 2017-07-08T04:13:48Z

sorry. been really busy at work. getting around to this now.

matthauck · 2017-07-08T04:41:44Z

woot! build passed! 🎉

ghost · 2017-08-11T14:03:06Z

How would you access this using withCredentials?

e.g: withCredentials([ssh-priv-key(credentialsId: '41341dc3-59fb-47c8-aa31-9d9931ee7c1c', variable: 'SSH-KEY')])

matthauck · 2017-08-14T20:16:21Z

Please see test for example usage: https://github.com/jenkinsci/credentials-binding-plugin/blob/master/src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java#L154

fpelz · 2017-09-11T22:01:51Z

How can I use this inside a Wrapper, like I would do for usernamePassword.

 wrappers { 
    credentialsBinding {
        // here the values from jenkins credentials are available as env. vars. 
        usernamePassword('CF_EMAIL', 'CF_PASSWORD', 'cf-dev-credential')

        // Similarly would like to put the path for the key and passphrase
        ssh('MY_KEY_PATH', 'MY_KEY_USER', 'MY_KEY_PASSPHRASE', 'my-key-id-jenkins-credentials')
   }
}

Is it possible with latest version?

sgalaviz · 2017-09-20T23:45:09Z

Hello,

I try the usage example (https://github.com/jenkinsci/credentials-binding-plugin/blob/master/src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SSHUserPrivateKeyTest.java#L154) as follow:

node {
	key = 'mykey'
	stage('Obtención de credenciales') {
		withCredentials([sshUserPrivateKey(keyFileVariable: 'THEKEY',
			passphraseVariable: 'THEPASS',
			usernameVariable: 'THEUSER', credentialsId: key)])
		{
			sh 'echo THEUSER=[$THEUSER] THEKEY=[$THEKEY] THEPASS=[$THEPASS]'
		}
	}
}

But didn't work because:

java.lang.NoSuchMethodError: No such DSL method 'sshUserPrivateKey' found among steps

Any advice is appreciated

mbarzare · 2017-10-09T19:41:41Z

I am using Jenkins 2.80 with a username / private key in my credentials. I am attempting to use the Credentials Binding Plugin v. 1.13 to retrieve the credentials with the sshUserPrivateKey binding and inject the results into a successive build step. My key does not have a passphrase. The following exception is what is being output in my build. Can anyone let me know if this is supported yet? My Google searches have not been promising. :(

java.lang.NullPointerException
	at hudson.EnvVars.override(EnvVars.java:132)
	at org.jenkinsci.plugins.credentialsbinding.impl.BindingStep$Overrider.expand(BindingStep.java:146)
	at org.jenkinsci.plugins.workflow.steps.EnvironmentExpander.getEffectiveEnvironment(EnvironmentExpander.java:122)
	at org.jenkinsci.plugins.workflow.support.DefaultStepContext.get(DefaultStepContext.java:66)
	at org.jenkinsci.plugins.workflow.steps.StepDescriptor.checkContextAvailability(StepDescriptor.java:258)
	at org.jenkinsci.plugins.workflow.cps.DSL.invokeStep(DSL.java:203)
	at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:150)
	at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:108)
	at sun.reflect.GeneratedMethodAccessor284.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93)
	at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1213)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022)
	at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:42)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
	at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:155)
	at org.kohsuke.groovy.sandbox.GroovyInterceptor.onMethodCall(GroovyInterceptor.java:23)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onMethodCall(SandboxInterceptor.java:133)
	at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:153)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:157)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:127)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:127)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:127)
	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.methodCall(SandboxInvoker.java:17)
	at WorkflowScript.run(WorkflowScript:20)
	at ___cps.transform___(Native Method)
	at com.cloudbees.groovy.cps.impl.ContinuationGroup.methodCall(ContinuationGroup.java:57)
	at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.dispatchOrArg(FunctionCallBlock.java:109)
	at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.fixArg(FunctionCallBlock.java:82)
	at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)
	at com.cloudbees.groovy.cps.Next.step(Next.java:83)
	at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:174)
	at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:163)
	at org.codehaus.groovy.runtime.GroovyCategorySupport$ThreadCategoryInfo.use(GroovyCategorySupport.java:122)
	at org.codehaus.groovy.runtime.GroovyCategorySupport.use(GroovyCategorySupport.java:261)
	at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:163)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.access$001(SandboxContinuable.java:19)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable$1.call(SandboxContinuable.java:35)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable$1.call(SandboxContinuable.java:32)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.GroovySandbox.runInSandbox(GroovySandbox.java:108)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.run0(SandboxContinuable.java:32)
	at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:174)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:330)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$100(CpsThreadGroup.java:82)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:242)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:230)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:64)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Finished: FAILURE

mbarzare · 2017-10-12T15:05:31Z

I should note that I finally discovered what I was doing wrong. To retrieve my key, I did the following in my Jenkinsfile:

withCredentials([sshUserPrivateKey(keyFileVariable: 'KEY', credentialsId: 'GITHUB_PRIVATE_KEY')]) 
{
sh 'echo GITHUB_KEY=$KEY'
}

Hope this helps someone else.

harmanbirdi · 2018-03-27T20:44:14Z

@mbarzare - I am trying to provide the "SSH User Private Key" that I have created globally to a promoted job. While it lets me create a "Credentials Parameter" and select "SSH Username with Private Key", and set its default value to my Global credential, when I echo it, I just see the UUID for the credentials.

How can I extract the username, and the private key from it? I have used the "SSH User Private Key" binding in the main Build section, but I need to access the same credentials to use in Promotions.

I am not sure how to use the UUID in a shell script to extract the credentials from the UUID.

Any help would be appreciated? Thanks.

matthauck · 2018-03-29T17:36:12Z

i think this github issue is becoming a support forum -- can we lock this issue maybe?

kormotodor · 2019-06-06T13:02:22Z

Sorry but is this documentation still correct according to this feature?

jglick · 2019-06-06T19:34:09Z

@kormotodor job-dsl hard-codes some things rather than using extension points plus @Symbol, so I would not expect it to have complete coverage.

kormotodor · 2019-06-07T09:50:27Z

@jglick So you mean, that it is impossible to call method "sshUserPrivateKey" from "credentialsBinding" plugin in dsl script on groovy for freestyle job? I expected exactly that behavior like when i use

job('example') {
    wrappers {
        credentialsBinding {
            file('KEYSTORE', 'keystore.jks')
        }
    }
}

just like in documentation is described.

jglick · 2019-06-07T14:12:05Z

@kormotodor I do not know, I do not maintain the job-dsl plugin. Please use a support forum for questions, or if you believe you have found a bug, file it under job-dsl-plugin in JIRA.

thomasgl-orange mentioned this pull request Sep 8, 2016

WIP: DockerServerCredentialsBinding (request for comments/discussion) #22

Closed

jglick changed the title ~~Add binding for SSH private keys~~ [JENKINS-28399] Add binding for SSH private keys Oct 11, 2016

jglick requested changes Oct 11, 2016

View reviewed changes

matthauck added 2 commits March 1, 2017 16:52

Add binding for SSH private keys

5c359ea

Add null check to fix findbugs

4faa3ff

matthauck force-pushed the ssh-key-creds branch from cce9aa2 to 4faa3ff Compare March 2, 2017 01:05

Updates per review feedback

f848c17

jglick mentioned this pull request Mar 23, 2017

Ease writing of new on-disk Binding implementations #25

Merged

jglick reviewed Mar 23, 2017

View reviewed changes

matthauck added 2 commits March 23, 2017 16:47

Make ssh-credentials required

af615a5

Updates per review

d632729

Merge branch 'master' into ssh-key-creds

8ad3421

thomasgl-orange mentioned this pull request May 19, 2017

Ease writing of new on-disk Binding implementations (take 2) #36

Merged

thomasgl-orange mentioned this pull request Jun 14, 2017

[JENKINS-28399] Add binding for SSH private keys (with PR #36) #38

Closed

jglick approved these changes Jun 21, 2017

View reviewed changes

matthauck and others added 5 commits June 26, 2017 11:38

Merge branch 'master' into ssh-key-creds

5406587

review feedback

4019ba3

Add helps htmls

be067e9

Add a @nonnull for key file

f82ee8e

switch to StringBuilder

11b26a2

jglick requested changes Jun 26, 2017

View reviewed changes

Try to add windows version of tests

3366d5c

jglick approved these changes Aug 8, 2017

View reviewed changes

jglick merged commit b141c6f into jenkinsci:master Aug 8, 2017

matthauck deleted the ssh-key-creds branch August 8, 2017 18:17

[JENKINS-28399] Add binding for SSH private keys #18

[JENKINS-28399] Add binding for SSH private keys #18

Uh oh!

Conversation

matthauck commented Jun 24, 2016 • edited by jglick Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthauck commented Aug 1, 2016

Uh oh!

matthauck commented Aug 31, 2016

Uh oh!

afalko commented Sep 29, 2016

Uh oh!

jglick commented Oct 11, 2016

Uh oh!

jglick commented Oct 11, 2016

Uh oh!

thomasgl-orange commented Oct 11, 2016

Uh oh!

matthauck commented Oct 11, 2016

Uh oh!

jglick commented Oct 11, 2016

Uh oh!

jglick Oct 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naphthalene commented Mar 1, 2017

Uh oh!

matthauck commented Mar 1, 2017

Uh oh!

naphthalene commented Mar 1, 2017

Uh oh!

matthauck commented Mar 2, 2017

Uh oh!

stephenc commented Mar 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

matthauck commented Jun 24, 2016 •

edited by jglick

Loading

jglick Oct 11, 2016 •

edited

Loading