Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Sep 25, 2018

No description provided.

@ndeloof
Copy link
Contributor Author

ndeloof commented Sep 25, 2018

This will allow to move custom Configurators out from support module to target plugin, without requirement for them to enable Beta annotation support
(also prevent weird classloading issue using hpi:run and third party plugin test suites)

@oleg-nenashev
Copy link
Member

I would prefer to keep it for a while so that we get more feedback.
But it is generally up to you and @ewelinawilkosz , @ndeloof

@ewelinawilkosz
Copy link
Contributor

I'm not strictly against, but I expect to release a number of 1.X with fixes we introduce constantly in upcoming weeks - 1.1 (?) is coming this week, so if @oleg-nenashev believes we can get some feedback will you both be ok with waiting till 1.2?

@ndeloof ndeloof merged commit f8e00b1 into jenkinsci:master Sep 26, 2018
@ndeloof
Copy link
Contributor Author

ndeloof commented Sep 26, 2018

Beta annotation is not just breaking hpi:run, it also prevent test-cases to run successfully for third party plugins

@ndeloof ndeloof deleted the beta branch September 26, 2018 07:00
@ndeloof
Copy link
Contributor Author

ndeloof commented Sep 26, 2018

see jenkinsci/job-dsl-plugin#1142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants