Conversation
There was a problem hiding this comment.
This plugin, as well as jekyll-feed, make use of page.last_modified_at. It would make more sense to use this instead of page.updated. This way the SEO tag would match what jekyll-feed outputs:
https://github.com/jekyll/jekyll-feed/blob/43cc5d51e30b59ab8d8ba970e42c8c437e2b233f/lib/jekyll-feed/feed.xml#L78
@ashmaroli otherwise this looks good I think? Pinging you directly as per a comment in #512 (comment) - despite not being the author of this PR, I wish to signal there is interest in this plugin.
|
I agree with @CookiePLMonster here. It would be better to use the |
|
Furthermore, even in this plugin, jekyll-seo-tag/spec/jekyll_seo_tag/drop_spec.rb Lines 298 to 315 in f449b1a Example from my website: |
|
@ashmaroli Looking at jekyll-seo-tag/lib/jekyll-seo-tag/drop.rb Lines 114 to 123 in f449b1a article:published_time isn't exactly great either and instead it should be seo_tag.published_time - it's used for LD-JSON already, but not for the HTML template. I can prepare an alternative PR tomorrow correcting this + modification date.
|
|
Additionally, this duplicates #447, albeit using |
add modified date meta tag, useful for SEO