Remove Travis test for Ruby 1.9#87
Remove Travis test for Ruby 1.9#87jekyllbot merged 1 commit intojekyll:masterfrom paulrobertlloyd:master
Conversation
|
Phew! Do let me know if I’ve made the right changes to the Travis config. @parkr @alfredxing |
|
Please don't modify It seems this would be best if it were just 408aeb6 without duplicating everything in #58 |
|
@pathawks Ah. I only updated Honestly, I’m happy whatever gets committed, just eager to see (and help!) things move forwards. |
|
@pathawks Okay, I’ve reduced the scope of this PR to that of supporting Jekyll 3.0 and above only. I’m guessing such a change necessitates moving to a major version bump? As such, I wonder if @alfredxing wants to include a few other updates and fixes in such a version? Not sure. FYI, I’m hoping to figure out how we can make this plugin accept any array of documents, so not just |
|
Looks good to me! Thanks @paulrobertlloyd 😄 It would be a breaking change, so unfortunately we would have to bump the major version 😦 I don't think this would be too much of an issue though; most people should be using Jekyll 3.0 by now! |
|
We can always remove support for 1.9.3 without removing support for Jekyll 2.0. It seems pretty easy to hold onto? |
pathawks
left a comment
There was a problem hiding this comment.
@paulrobertlloyd Would you mind squashing changes, so we don't alter the Git history of History.markdown? I can help with that, if you need.
|
@pathawks Happy to squash. I’ve never done this before, so do please let me know what steps I need to take. @alfredxing @parkr Oh, maybe I could limit this PR to the Travis config, and to remove testing on Ruby 1.9.3? I wrongly assumed there was a stronger link between Ruby 1.9.3 and Jekyll 2.0, but I guess older versions of Jekyll 2.0 will work with newer flavours of Ruby. |
|
@paulrobertlloyd You can squash commits easily with GitKraken GUI. https://support.gitkraken.com/working-with-files/commits 👍 for a simple PR that removes testing on Ruby 1.9.x |
|
Or from command line: |
|
@paulrobertlloyd ❤️👍 |
|
@jekyllbot: merge +dev |

Hello @jekyll/archives. In the interests of keeping development of this important (IMHO!) plugin progressing, and in the spirit of being proactive (and following on from the discussion in #58), I’ve updated the Travis tests to remove tests for Ruby 1.9
/Jekyll 2.0.Somewhat related, I removed the version forking in the code, and bumped the minimum supported Jekyll version to 3.0. Controversial? Maybe, but Jekyll 3.0 is 15 months old now. Ducks