Repository navigation
Convert bools to lowercase for XML spec compliance - #271
Merged
Merged
Conversation
jeffkl
reviewed
Mar 7, 2024
`bool.ToString()` returns an uppercase "True" or "False", but XML is case sensitive and speicifes that bools should be lowercase (see https://learn.microsoft.com/en-us/dotnet/api/system.boolean.tostring). While the built-in NuspecReader handles this, tools like NuGet Package Explorer to not. Update the nuspec writer in Package to emit lowercase bools, and update unit test to catch accidental regressions.
MattKotsenas
force-pushed
the
bugfix/nuspec-parsing
branch
from
March 7, 2024 18:45
e61d184 to
5c9d62e
Compare
jeffkl
enabled auto-merge (squash)
March 7, 2024 18:55
Contributor
Author
|
whoops! directory separator issues; taking a look... |
Owner
There's an overload to |
auto-merge was automatically disabled
March 7, 2024 19:29
Head branch was pushed to by a user without write access
Contributor
Author
Thanks! I needed to both use that to normalize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bool.ToString()returns an uppercase "True" or "False", but XML iscase sensitive and specifies that bools should be lowercase (see
https://learn.microsoft.com/en-us/dotnet/api/system.boolean.tostring).
While the built-in NuspecReader handles this, tools like NuGet Package
Explorer do not. Update
Package.WriteNuspecto emit lowercasebools.
I also added a basic unit test to catch accidental regressions.