Fix fare checking for basic fares#391
Open
razzamatazm wants to merge 2 commits intojdholtz:masterfrom
Open
Conversation
Author
|
Well - this works so long as the flyer doesn't have a companion linked to their reservation, as that requires cancelling the companion reservation first. I found a method of pulling the price paid in points if the flyer is using the account method of getting their reservations via the rapid rewards profile portal, but that does not provide purchase amounts in $$$. It's pretty obvious SW does not want to remind you how much you paid for your flights, as the price you paid for historical flights is very easily displayed. |
Owner
|
Thanks @razzamatazm! Hoping to have the time to do a review of this in the next few days |
|
Would love to get this in! @jdholtz, sure you are busy though :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix fare checking for non-changeable basic fares by reading the booked WGA amount from the cancel refund quote API
Testing
.venv/bin/pytest -p no:rerunfailures tests/unit/test_fare_checker.py\n
.venv/bin/pytest -p no:rerunfailures tests/integration/test_fare_checker.py
Fixes Element {.login-button--box} was not present after 7 seconds! #379
Fixes Basic Fares not being detected? #386