Improve debug logging for sleep durations in check-in and reservation…#388
Improve debug logging for sleep durations in check-in and reservation…#388ramalamadingdong wants to merge 1 commit intojdholtz:masterfrom
Conversation
|
Hey @ramalamadingdong, thanks for this PR. The reason I didn't include the sleep duration in the log is because it would give anyone reading the logs knowledge of the flight the user is on based on the check-in time (if it is within 2 weeks). I've been careful to log as little private info in the logs as possible (in fact, I don't believe there is any), so I'm hesitant to include this in the log. What do you think would be the advantage of logging this info? |
|
Sorry about that! I ended up freaking out because I didn't read that the time printed was actually the time for sleeping for 24 hours and it freaked me out a bit. I totally get the privacy concern if people are posting the logs online. |
Gotcha. How about changing the 'Sleeping for %d seconds' to something like 'Monitor sleeping until next check (%d seconds)' so that's not ambiguous as to if it is the check-in or just a normal check? And then not logging the time for the check-in? |
|
sounds great! Happy to change the comment and close this PR |
|
Hey @ramalamadingdong, did you want to make the changes so we can get this merged? |
|
Yes I'll do that this week. Sorry about that |
Fixed the sleep (seconds in the debugging output)