Wait for spinner to be hidden before clicking#1
Merged
jdholtz merged 1 commit intojdholtz:masterfrom Apr 17, 2022
Merged
Conversation
Owner
|
Thanks! I wonder if this should be done to the check-in function that uses the same method... Since you used Also, it might be better to use I am not very experienced with selenium though, so I could be totally wrong. |
Contributor
Author
|
Unfortunately it didn't work when I tried just setting
EC.element_to_be_clickable.
I had to wait for the spinner loader to be hidden then it let the click
happen.
…On Sat, Apr 16, 2022, 7:59 PM Joey H ***@***.***> wrote:
Thanks! I wonder if this should be done to the check-in function that uses
the same method...
Since you used EC.element_to_be_clickable, from my understanding, you
wouldn't need to wait for the spinner to disappear because the driver
wouldn't try to click the element until it is able to.
Also, it might be better to use EC.element_to_be_clickable everywhere
instead of EC.presence_of_element_located to mitigate any more errors
like this one.
I am not very experienced with selenium though, so I could be totally
wrong.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATA63E2D4Z2GFFKHNLMI2TDVFNO6TANCNFSM5TSRNRSQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jdholtz
added a commit
that referenced
this pull request
Apr 30, 2022
The latest version of undetected_chromedriver fixes running multiple browsers at the same time. Also, the latest version of undetected_chromedriver adds the --no-sandbox flag by default, so that is not needed. The --disable-dev-shm-usage flag might need to be added when I add a Docker implementation, but for right now it is useless.
Owner
|
Accidentally referenced this in a commit message. It was meant for #2. Fixed now |
Closed
This was referenced Mar 15, 2023
jtc268
pushed a commit
to jtc268/auto-southwest-check-in
that referenced
this pull request
Aug 21, 2025
Wait for spinner to be hidden before clicking --Note: Might need to be added to the check-in function as well. Also look into using 'element_to_be_clickable' instead of 'presence_of_element_located' for every element.
jtc268
pushed a commit
to jtc268/auto-southwest-check-in
that referenced
this pull request
Aug 21, 2025
ctkubik
pushed a commit
to ctkubik/auto-southwest-check-in
that referenced
this pull request
Mar 29, 2026
Flight C3GDAI's check-in FAILED because the seat upgrade function held browser_session._lock for 10+ minutes while navigating www.southwest.com. When the check-in thread (24h before departure) tried to acquire the lock, it was blocked. When it finally got the lock, the browser was on www.southwest.com (not mobile.southwest.com), causing fetch() to fail with status 0 (same-origin policy violation). Three fixes: 1. CRITICAL: Check-in proximity guard (worker.py) - attempt_seat_upgrades() now checks if ANY check-in is within 2 hours. If so, seat upgrades are PAUSED entirely. - Check-in is always the jdholtz#1 priority. Seat upgrades can wait. - Activity log shows: "Seat upgrades PAUSED: check-in for X in Y minutes" 2. HIGH: Fresh browser session before check-in (checkin_handler.py) - 30 minutes before check-in, the handler now calls browser_session.start() (not just ensure_alive()) - This creates a completely fresh browser on mobile.southwest.com - Guarantees the browser is on the correct domain with fresh WAF tokens, regardless of what seat upgrades did earlier 3. MEDIUM: Lock timeout in make_request (browser_session.py) - Changed from blocking `with self._lock:` to timed acquisition `self._lock.acquire(timeout=60)` - If the lock can't be acquired within 60 seconds, logs a warning and retries instead of blocking indefinitely - Prevents check-in from being stuck waiting for seat upgrade forever https://claude.ai/code/session_01XeexS9xn1dz8wb9K11MkpV
e280l132
pushed a commit
to e280l132/auto-southwest-check-in
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was crashing trying to click on the login box before the spinner disappeared. This will now wait for the Spinner to be invisible and the Login button to be clickable.
Fixes this error:
selenium.common.exceptions.ElementClickInterceptedException: Message: element click intercepted: Element ... is not clickable at point (1849, 28). Other element would receive the click: