Skip to content

Conversation

@merceyz
Copy link

@merceyz merceyz commented May 20, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix, adds express-session as a peer dependency.

Fixes yarnpkg/berry#4368

  • What is the current behavior? (You can also link to an open issue here)

connect-mongo crashes when attempting to require express-session if the hoisting didn't make it accessible.

  • Checklist:

    • Added test cases
    • Updated changelog

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 21, 2022
@mingchuno
Copy link
Collaborator

Close as this is fixed in master and released

@stale stale bot removed the wontfix label Mar 14, 2023
@mingchuno mingchuno closed this Mar 14, 2023
@merceyz merceyz deleted the patch-1 branch March 14, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: @yarnpkg/esbuild-plugin-pnp is not bundling express-session

2 participants