Add constrained decoding #480
Open
+304
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicheng0816
requested review from
DragonFive,
liujinguang0125,
liutongxuan,
walsonyang and
yq33victor
magicheng0816
force-pushed
the
add_constrained_decoding
branch
from
cd1fdce to
e0d7b6a
Compare
linkerzhang
reviewed
Dec 3, 2025
|
|
||
| // Input generated_token_list: [sequence_num][generated_token_ids] | ||
| // Output: mask tensor[sequence_num,vocab_size] | ||
| virtual torch::Tensor generate_mask( |
Member
There was a problem hiding this comment.
There'll be a data copy when calling this function, right? if it's heavy, it should be avoided.
Collaborator
Author
There was a problem hiding this comment.
There is no heavy data copying. First, an initialized tensor is generated on the device side based on the vocab size. Then, a valid token index set is dynamically obtained from the already generated tokens on the host side, copied to the device side, and the initialized tensor is modified in-place to form a mask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.