SET-626 Olympus - Ensure Ansible updates Nginx images #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyrkob
reviewed
Feb 15, 2024
roles/nginx/tasks/nginx_update.yml
Outdated
|
|
||
| - name: Store current nginx image value in a variable | ||
| set_fact: | ||
| nginx_latest_image_tag: "{{ local_image_tags.results[0].images[0].RepoTags[0] }}" |
Contributor
There was a problem hiding this comment.
IIUC that assumes that nginx is always the first result returned, is that correct?
If so, that works currently because it's the only remote image, but if we add a new remote image wouldn't this start failing in unexpected ways?
Contributor
Author
There was a problem hiding this comment.
Thanks! Modified the PR accordingly.
| nginx_latest_image_tag: "{{ local_image_tags.results[0].images[0].RepoTags[0] }}" | ||
|
|
||
| - name: Pull the latest Nginx image | ||
| shell: "podman pull {{ nginx.latest_image }}" |
Contributor
There was a problem hiding this comment.
I'm probably missing something, but where is the nginx.latest_image defined?
Contributor
Author
There was a problem hiding this comment.
I missed adding the vars. modified it.
RanabirChakraborty
force-pushed
the
SET--626
branch
from
e1e91d6 to
07f027a
Compare
Contributor
|
@RanabirChakraborty I still need to find some time to review this, but, in the meantime, can you rebase and push? |
RanabirChakraborty
force-pushed
the
SET--626
branch
from
07f027a to
7a8a11d
Compare
Contributor
Author
|
@rpelisse thanks! I have done the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/SET-626