Repository navigation
Fix type reference name in attribute argument getting mangled when - #722
Merged
Merged
Conversation
jbevain
reviewed
Feb 9, 2021
| { | ||
| var module = GetCurrentModule (); | ||
| var cecil = module.AssemblyReferences.Where (reference => reference.Name == "Mono.Cecil").First (); | ||
| var cecil = module.AssemblyReferences.Where (reference => reference.Name == "Unity.Cecil").First (); |
mrvoorhe
force-pushed
the
master-winrt-fix
branch
from
February 10, 2021 14:43
b3ad5f9 to
3891384
Compare
Contributor
Author
|
I can't tell if a test failed or if there was some CI instability. All I see in the log is |
mrvoorhe
force-pushed
the
master-winrt-fix
branch
from
February 11, 2021 12:58
3891384 to
1a32d9b
Compare
Contributor
Author
|
Looks like it was a CI instability. I force pushed to trigger a new CI run and now the tests are green. |
Owner
|
Yeah that's NuGet having hiccups. |
jbevain
reviewed
Feb 11, 2021
| private void WriteCustomAttributeTypeValue (TypeReference value) | ||
| { | ||
| var typeDefinition = value as TypeDefinition; | ||
| TypeDefinition outermostDeclaringType = typeDefinition; |
Owner
There was a problem hiding this comment.
Could you move this into the if branch?
…ch attribute is put on a method in a projected type.
mrvoorhe
force-pushed
the
master-winrt-fix
branch
from
February 11, 2021 18:53
1a32d9b to
b4eef32
Compare
jbevain
approved these changes
Feb 11, 2021
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
such attribute is put on a method in a projected type.
This is a fix that Unity's cecil has had for a couple years.