Skip to content

Changing PdbReaderProvider to accept create EmbeddedPDB from stream. - #648

Merged
jbevain merged 2 commits into
jbevain:masterfrom
thaystg:thays_read_embedded_pdb
Feb 12, 2020
Merged

jbevain merged 2 commits into
jbevain:masterfrom
thaystg:thays_read_embedded_pdb

Conversation

@thaystg

@thaystg thaystg commented Feb 12, 2020

Copy link
Copy Markdown
Contributor

Changing GetSymbolReader from PdbReaderProvider, when we create a Module from stream we don't have the filename, and it's not necessary to create an EmbeddedPortablePdbReaderProvider, so I've moved the check to after the creation of EmbeddedPortablePdbReaderProvider.

…ule from stream we don't have the filename, and it's not necessary to create an EmbeddedPortablePdbReaderProvider, so I've moved the check to after the creation of EmbeddedPortablePdbReaderProvider.
@thaystg
thaystg requested a review from jbevain February 12, 2020 18:56

@jbevain jbevain left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please just address the comment and this will be good to go.

[Test]
public void EmbeddedCompressedPortablePdbFromStream ()
{
TestBinary("EmbeddedCompressedPdbTarget.exe", module => {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make this simpler and not create infrastructure for reading modules as in memory. You can undo all the changes in BaseTestFixture, and in this test you can use:

var bytes = File.ReadAllBytes (GetAssemblyResourcePath ("EmbeddedCompressedPdbTarget.exe"))

Create the module from that and run the test.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jbevain
jbevain merged commit 7d2479e into jbevain:master Feb 12, 2020
@jbevain

jbevain commented Feb 12, 2020

Copy link
Copy Markdown
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants