Repository navigation
Fix locally scoped constant array - #644
Merged
jbevain merged 5 commits intoJan 31, 2020
Merged
Conversation
Contributor
Author
|
put in a diff PR since i am confident the fail test verifies the scenario. but am uncertain about this as a fix |
jbevain
requested changes
Jan 30, 2020
Owner
|
Thanks for the PR. The fix is good! |
jbevain
approved these changes
Jan 31, 2020
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jbevain seems to me an array should be treated the same as a object type for this context?