Skip to content

Fix locally scoped constant array - #644

Merged
jbevain merged 5 commits into
jbevain:masterfrom
SimonCropp:possibleFixForLocallyScopedConstantArray
Jan 31, 2020
Merged

jbevain merged 5 commits into
jbevain:masterfrom
SimonCropp:possibleFixForLocallyScopedConstantArray

Conversation

@SimonCropp

Copy link
Copy Markdown
Contributor

@jbevain seems to me an array should be treated the same as a object type for this context?

@SimonCropp

Copy link
Copy Markdown
Contributor Author

put in a diff PR since i am confident the fail test verifies the scenario. but am uncertain about this as a fix

Comment thread Test/Mono.Cecil.Tests/ImageReadTests.cs Resolved
@jbevain

jbevain commented Jan 30, 2020

Copy link
Copy Markdown
Owner

Thanks for the PR. The fix is good!

@jbevain jbevain changed the title Possible fix for locally scoped constant array Fix locally scoped constant array Jan 31, 2020
@jbevain
jbevain merged commit 933575c into jbevain:master Jan 31, 2020
@jbevain

jbevain commented Jan 31, 2020

Copy link
Copy Markdown
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants