Skip to content

Reduce some GC pressure that adds up in several unity workloads. - #633

Merged
jbevain merged 6 commits into
jbevain:masterfrom
lucasmeijer:master
Dec 8, 2019
Merged

jbevain merged 6 commits into
jbevain:masterfrom
lucasmeijer:master

Conversation

@lucasmeijer

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Mono.Collections.Generic/Collection.cs Resolved
@jbevain jbevain changed the title Reduce some GC pressure that adds up in severla unity workloads. Reduce some GC pressure that adds up in several unity workloads. Dec 6, 2019
@jbevain

jbevain commented Dec 6, 2019

Copy link
Copy Markdown
Owner

We just need to address the tidbit and that's good to go. Thanks for the contribution!

Comment thread Mono.Cecil/GenericInstanceType.cs Resolved
@jbevain
jbevain merged commit 797ee89 into jbevain:master Dec 8, 2019
@jbevain

jbevain commented Dec 8, 2019

Copy link
Copy Markdown
Owner

Thanks again!

@SimonCropp

Copy link
Copy Markdown
Contributor

@lucasmeijer do you have any indicative numbers on the perf improvements this results in?

@lucasmeijer

Copy link
Copy Markdown
Contributor Author

@SimonCropp no, the workload I was testing on has high varience, but on many dottrace traces Collection.Grow did show up, and the two causes were the sequencepoints and the generic instantiation arguments. This is definitely in the small fish category.

@SimonCropp

Copy link
Copy Markdown
Contributor

@lucasmeijer thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants