Skip to content

Conversation

@ADTC
Copy link
Contributor

@ADTC ADTC commented Jan 20, 2024

Some of the tables are really wide due to non-wrapping code blocks. The columns were also not distributed well due to large code blocks in Type and Default columns. There were also several mistakes in the content.

This pull request:

  • Fixes the width of table columns by allowing wrap on code blocks.
  • Unsets the line-height of code blocks, to make them look nicer.
  • Fix some mistakes in code like missing brackets, missing lambda arrows, missing code blocks, lost cell, etc.
  • Move the longer Type and Default column values into the Description. This better distributes the table columns so the description has more space.
    • Where moved, the original cell has "See description" in it now for guidance.

Preview:

@netlify
Copy link

netlify bot commented Jan 20, 2024

Deploy Preview for react-data-table-component ready!

Name Link
🔨 Latest commit 9d5b3fa
🔍 Latest deploy log https://app.netlify.com/sites/react-data-table-component/deploys/65b06907b7f14b0009a4f6e3
😎 Deploy Preview https://deploy-preview-1206--react-data-table-component.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ADTC ADTC changed the title Fix width of table columns and fix some mistakes Fix width of table columns and fix some mistakes in Storybook (Netlify) Jan 20, 2024
@ADTC
Copy link
Contributor Author

ADTC commented Jan 20, 2024

@jbetancur just let me know if I missed something.

The !important keyword is necessary because the generated class name that applies overriding styles has a higher specificity than the element tag selector.
@ADTC
Copy link
Contributor Author

ADTC commented Jan 24, 2024

@jbetancur I've removed the generated class name now. Note: The !important keyword is necessary because the generated class name that applies overriding styles has a higher specificity than the element tag selector, so we need to force-override it.

@jbetancur jbetancur merged commit d22b934 into jbetancur:master Jan 26, 2024
@ADTC ADTC deleted the fix-table-width branch January 26, 2024 14:33
@ADTC
Copy link
Contributor Author

ADTC commented Jan 26, 2024

Thank you! I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants