added automatic url_rule generation in route()-decorator#92
Open
dersphere wants to merge 1 commit intojbeluch:developfrom
Open
added automatic url_rule generation in route()-decorator#92dersphere wants to merge 1 commit intojbeluch:developfrom
dersphere wants to merge 1 commit intojbeluch:developfrom
Conversation
Contributor
Author
|
What about this? Is this something you consider for xbmcswift? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is something you/we really want, so I only updated the code. If you like it, I can add tests and update the docs.
With this change the following is possible:
The URLs from the above example will be:
It could also be changed to not add the param name, example:
This change should be fully backward compatible.
Personally I prefer defining the routes myself but while in development it saves some time. ;-)