Skip to content

Override self.request with the new request when redirecting #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adammw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Override self.request with the new request when redirecting #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions xbmcswift2/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,10 @@ def _dispatch(self, path):
def redirect(self, url):
'''Used when you need to redirect to another view, and you only
have the final plugin:// url.'''
# TODO: Should we be overriding self.request with the new request?
new_request = self._parse_request(url=url, handle=self.request.handle)
log.debug('Redirecting %s to %s', self.request.path, new_request.path)
return self._dispatch(new_request.path)
original_request = self.request
self._request = self._parse_request(url=url, handle=original_request.handle)
log.debug('Redirecting %s to %s', original_request.path, self.request.path)
return self._dispatch(self.request.path)

def run(self, test=False):
'''The main entry point for a plugin.'''
Expand Down