Open
Conversation
First, chdkptp errors do not have a 'message' key, instead, it is 'msg'. Then, for some reason the dictionary get() method throws an error: TypeError: 'NoneType' object is not callable no matter if the key exists, or not. Not sure why that is so.
…aries nicely. Since they have special properties like the PTP traceback.
Author
|
The second commit is to expose the PTPError class so client libraries can catch it and parse it correctly, for example, by doing something with the PTP traceback property it has. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, chdkptp errors do not have a 'message' key, instead, it is 'msg'.
Then, for some reason the dictionary get() method throws an error:
no matter if the key exists, or not. Not sure why that is so.
For example, using str(parse_table(err_table)), the structure of err_table is as follows:
then the following error is thrown when using get() (no matter which key, just for example here is ptp_rc):
but using err_table['ptp_rc'], it will correctly get that key.
Not sure why that happens, but the simple fix is to use brackets. Yes it will throw if the key doesn't exists, but currently it is throwing in all cases, so at the very least, it is better than the current situation ;)