-
Notifications
You must be signed in to change notification settings - Fork 202
Feature: Memory Banks (Windows Only) #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b869253
add removable attribute to disk object
thetravischannel 14f6756
update removable attribute naming for consistency
thetravischannel 106f054
Windows partial support - Baseboard, BIOS, chassis, product
a6e7bb1
update darwin removable attribute to match consistency changes
thetravischannel d6f0aa3
new logo/mascot
thetravischannel 99f18cd
Product UUID
46c4d16
Using private win32 structs and static vmi queries
5f7cd38
Windows support: cpu, memory (#155)
KingRial 1df95ac
Windows support: block
0e96671
Feature: Memory Banks (Windows Only)
f90bcd9
address review comments
jaypipes 6e02c37
Merge branch 'master' into win_memory_feature_banks
jaypipes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR (not this one), I'd be interested in adding a
Speedfield to theMemoryModulestruct. Need to have a conversation about what the appropriate data type is, though, so let's leave that for a future commit.