-
Notifications
You must be signed in to change notification settings - Fork 0
Bump Node to 22 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! |
|
@ScottBrenner - looks like this broke things: |
This reverts #1, and fixes db55d6c which moved to 20, but incompletely. Signed-off-by: Phil Dibowitz <[email protected]>
This reverts #1, and fixes db55d6c which moved to 20, but incompletely. Signed-off-by: Phil Dibowitz <[email protected]>
|
|
|
BTW I cleaned up the setup instructions and submitted it to Marketplace. |
|
Ah sorry, was on mobile when I sent that and did not type it out entirely- setup-node@v4 works perfectly fine with Node 22, as logged by the passing job in this PR - https://github.com/jaymzh/main-branch-check-action/pull/1/checks#step:3:9 That error is logged by the "runner", on which this action is executed - commented regarding this on https://github.com/actions/runner/discussions/2704#discussioncomment-9515846 |
|
Good call. Though it still meant referring to 20. Thanks for reporting that I'll keep an eye on it. |
Recreating openai/main-branch-check-action#12 here