Skip to content

Conversation

@ScottBrenner
Copy link
Contributor

@ScottBrenner ScottBrenner marked this pull request as ready for review May 21, 2024 05:08
@jaymzh jaymzh merged commit 2fa5938 into jaymzh:main May 21, 2024
@jaymzh
Copy link
Owner

jaymzh commented May 21, 2024

Thanks!

@ScottBrenner ScottBrenner deleted the patch-1 branch May 21, 2024 14:58
@jaymzh
Copy link
Owner

jaymzh commented May 21, 2024

@ScottBrenner - looks like this broke things:

Download action repository 'jaymzh/main-branch-check-action@main' (SHA:2fa5938f39733174b68c0e6b4a44ae9f745f451a)
Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node22' is not supported, use 'docker', 'node12', 'node16' or 'node20' instead.')

jaymzh added a commit that referenced this pull request May 21, 2024
This reverts #1, and fixes
db55d6c
which moved to 20, but incompletely.

Signed-off-by: Phil Dibowitz <[email protected]>
jaymzh added a commit that referenced this pull request May 21, 2024
This reverts #1, and fixes
db55d6c
which moved to 20, but incompletely.

Signed-off-by: Phil Dibowitz <[email protected]>
@ScottBrenner
Copy link
Contributor Author

ScottBrenner commented May 21, 2024

@jaymzh
Copy link
Owner

jaymzh commented May 21, 2024

setup-node@v4 is what complained...

@jaymzh
Copy link
Owner

jaymzh commented May 21, 2024

BTW I cleaned up the setup instructions and submitted it to Marketplace.

@ScottBrenner
Copy link
Contributor Author

Ah sorry, was on mobile when I sent that and did not type it out entirely-

setup-node@v4 works perfectly fine with Node 22, as logged by the passing job in this PR - https://github.com/jaymzh/main-branch-check-action/pull/1/checks#step:3:9

That error is logged by the "runner", on which this action is executed - commented regarding this on https://github.com/actions/runner/discussions/2704#discussioncomment-9515846

@jaymzh
Copy link
Owner

jaymzh commented May 22, 2024

Good call. Though it still meant referring to 20. Thanks for reporting that I'll keep an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants