Right now MendableReportGeneratorRequest only supports a single String scan path.
|
@Poko |
|
public class MendableReportGeneratorRequest( |
|
public val scanPath: String, |
|
public val outputPath: String, |
|
public val scanRecursively: Boolean, |
|
public val outputFileName: String, |
|
public val exportType: ExportType, |
|
public val includeModules: IncludeModules, |
|
) { |
And as different projects would have different ways of generating and storing the metrics, having a single scan path will force the library consumers to either have all of the metrics generated in a single folder, or scan a much bigger parent folder recursively to fit the single scan path requirement. Which isn't ideal.
Instead, it is better to change the primary constructor to take in a list of scan paths, and add a secondary constructor with a single scan path (which will ultimately call the primary constructor with a list of only one scan path) to maintain source-compatibility.
TODO:
Right now
MendableReportGeneratorRequestonly supports a singleStringscan path.mendable/mendable/src/main/java/com/jayasuryat/mendable/MendableReportGeneratorRequest.kt
Lines 32 to 40 in 0009acc
And as different projects would have different ways of generating and storing the
metrics, having a singlescan pathwill force the library consumers to either have all of the metrics generated in a single folder, or scan a much bigger parent folderrecursivelyto fit the single scan path requirement. Which isn't ideal.Instead, it is better to change the
primary constructorto take in alistofscan paths, and add asecondary constructorwith a singlescan path(which will ultimately call theprimary constructorwith alistof only onescan path) to maintainsource-compatibility.TODO:
MendableReportGeneratorRequestto accommodate for multiplescan pathsMendableReportGeneratorRequestbackwards-source-compatibleMendableReportGeneratorto handle multiplescan pathsCliArgsto take in multiplescan pathsCliArgumentsTestto test the change in behaviourUpdateREADME.mdto inform about this changebackwards-source-compatibility