BUG: fix float divmod with zero denominator #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apivovarov
reviewed
Aug 23, 2024
jakevdp
force-pushed
the
divmod
branch
3 times, most recently
from
9b6e79b to
a78533b
Compare
hawkinsp
approved these changes
Aug 23, 2024
Collaborator
hawkinsp
left a comment
hawkinsp
left a comment
There was a problem hiding this comment.
Looks good to me, but I'd appreciate @apivovarov 's review as well.
jakevdp
force-pushed
the
divmod
branch
3 times, most recently
from
4414ef0 to
f57d63b
Compare
Collaborator
Author
|
Pulling in for further testing |
apivovarov
reviewed
Aug 23, 2024
| truncate(expected, float_type=float_type), | ||
| rtol=0.0, | ||
| float_type=float_type, | ||
| ) |
Contributor
There was a problem hiding this comment.
Thank you for adding this test!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170