Objects #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lighthousand merged 5 commits into javascript-tutorial:master from armino-dev:master

Dec 11, 2019

Contributor

armino-dev commented Dec 9, 2019

Hi,
I have finished the first version of "Objects" translation to Romanian.
I hope it's good.

armino-dev added 3 commits

December 8, 2019 11:10


          Partial translation of article.md

8ab4ab8


          First translation

80b30ae


          Tasks and solutions translated

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

December 9, 2019 06:37

iliakan mentioned this pull request

Romanian Translation Progress #1

Open

claassistantio commented Dec 9, 2019 •

edited

Loading

All committers have signed the CLA.

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved


          Resolved translation issues pointed on review

09eb7f3

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand reviewed

View reviewed changes

1-js/04-object-basics/01-object/article.md Outdated Show resolved Hide resolved

lighthousand requested changes

View reviewed changes

Member

lighthousand left a comment

Good job !

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Dec 9, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻


          Some more corrections

e4114e9

Contributor Author

armino-dev commented Dec 10, 2019

/done

javascript-translate-bot added review needed and removed changes requested labels

javascript-translate-bot requested a review from a team

December 10, 2019 06:24

lighthousand approved these changes

View reviewed changes

javascript-translate-bot removed the review needed label

javascript-translate-bot added the needs +1 label

lighthousand merged commit b168cfe into javascript-tutorial:master

javascript-translate-bot commented Dec 11, 2019

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels