1- Js #63
Merged
1- Js #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmodHammad
approved these changes
Jun 5, 2020
mahmodHammad
left a comment
mahmodHammad
left a comment
There was a problem hiding this comment.
Nice work👍
But i thing It could be better if you can change the translation of string to
سلسلة الحروف) (كلمه
| @@ -1,120 +1,120 @@ | |||
| # JavaScript specials | |||
| # خاصّيات جافاسكريبت | |||
Contributor
Author
There was a problem hiding this comment.
تمام فعلاً خواص أفضل
| - `object` and `symbol` -- for complex data structures and unique identifiers, we haven't learnt them yet. | ||
| - `number` لكل من الأرقام العشرية والأرقام الصحيحة، | ||
| - `bigint` للأرقام الصحيحة غير محددة الطول، | ||
| - `string` لسلاسل المحارف, |
Contributor
Author
There was a problem hiding this comment.
بس ال String مو شرط يكون سلسة حروف فقط ليشكل كلمة، ممكن نستخدم المحارف أيضاً.
بظن سلسلة محارف أدق.
There was a problem hiding this comment.
هوا بس لو حد شاف سلسلة المحارف ممكن ميفهمش منها المقصود
ممكن سلسة الاحرف ادق
ولو كتبنا جنبها
(كلمه)
هاتيفهم المقصود
و جزاء الله خيرا علي المجهود ده
OmarioHassan
approved these changes
Jun 5, 2020
Contributor
OmarioHassan
left a comment
OmarioHassan
left a comment
There was a problem hiding this comment.
Awesome work ⚡⚡⚡ keep going
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate "JavaScript Specials" into Arabic.