Skip to content

Conversation

@seokjun7410
Copy link
Contributor

Fixes #4817.

Remove switch statement for primitiveType in LexicalPreservingPrinter

@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.335%. Comparing base (ef6975d) to head (071e827).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4823       +/-   ##
===============================================
+ Coverage     58.326%   58.335%   +0.009%     
  Complexity      2518      2518               
===============================================
  Files            671       671               
  Lines          38826     38808       -18     
  Branches        7054      7053        -1     
===============================================
- Hits           22646     22639        -7     
+ Misses         13295     13284       -11     
  Partials        2885      2885               
Flag Coverage Δ
AlsoSlowTests 58.335% <100.000%> (+0.009%) ⬆️
javaparser-core 58.335% <100.000%> (+0.009%) ⬆️
javaparser-symbol-solver 58.335% <100.000%> (+0.009%) ⬆️
jdk-10 57.887% <100.000%> (+0.013%) ⬆️
jdk-11 57.886% <100.000%> (+0.008%) ⬆️
jdk-12 57.886% <100.000%> (+0.008%) ⬆️
jdk-13 57.886% <100.000%> (+0.008%) ⬆️
jdk-14 58.133% <100.000%> (+0.008%) ⬆️
jdk-15 58.133% <100.000%> (+0.008%) ⬆️
jdk-16 58.108% <100.000%> (+0.008%) ⬆️
jdk-17 58.262% <100.000%> (+0.011%) ⬆️
jdk-18 58.262% <100.000%> (+0.011%) ⬆️
jdk-8 57.888% <100.000%> (+0.008%) ⬆️
jdk-9 57.884% <100.000%> (+0.008%) ⬆️
macos-latest 58.328% <100.000%> (+0.009%) ⬆️
ubuntu-latest 58.323% <100.000%> (+0.009%) ⬆️
windows-latest 58.317% <100.000%> (+0.009%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../com/github/javaparser/ast/type/PrimitiveType.java 65.671% <100.000%> (ø)
.../lexicalpreservation/LexicalPreservingPrinter.java 80.779% <100.000%> (+1.126%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522d8fa...071e827. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlerbsc jlerbsc merged commit 5146016 into javaparser:master Aug 23, 2025
35 checks passed
@jlerbsc
Copy link
Collaborator

jlerbsc commented Aug 23, 2025

Thank you for this PR

@jlerbsc jlerbsc added this to the next release milestone Aug 23, 2025
@jlerbsc jlerbsc added the PR: Changed A PR that changes implementation without changing behaviour (e.g. performance) label Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Changed A PR that changes implementation without changing behaviour (e.g. performance)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants