Skip to content

fix: Update jac-mcp-chatbot backend with the latest jaseci stack#492

Merged
udithishanka merged 1 commit intojaseci-labs:mainfrom
Hirudika4:dev5
Feb 16, 2026
Merged

fix: Update jac-mcp-chatbot backend with the latest jaseci stack#492
udithishanka merged 1 commit intojaseci-labs:mainfrom
Hirudika4:dev5

Conversation

@Hirudika4
Copy link
Collaborator

  • Changed the text parameter in both ImageChat.chat and VideoChat.chat to explicitly use the Text type, ensuring message content is consistently typed throughout the codebase.
  • Updated walker and router initialization and routing logic to use Root entry and the ?: syntax for more robust and explicit node selection.
  • Modified the instantiation of the llm global to pass the verbose flag via the config dictionary.
  • Updated the import for the Document class to use langchain_core.documents instead of langchain.schema.document, aligning with the latest library structure.
  • Fixed the command in the README.md to use jac start instead of the outdated jac serve.

Copilot AI review requested due to automatic review settings February 16, 2026 09:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the jac-mcp-chatbot backend to align with the latest jaseci stack conventions, including modernizing Jac syntax, updating library imports, and fixing documentation. The PR addresses syntax deprecations and ensures consistency with the current Jac language specification.

Changes:

  • Updated Jac walker syntax from legacy backtick notation to modern Root entry and (?:Type) node filter syntax
  • Migrated langchain Document import from deprecated langchain.schema.document to langchain_core.documents
  • Wrapped text parameters with explicit Text() type constructors for type consistency in Image/VideoChat methods
  • Updated README command from deprecated jac serve to jac start

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tools.jac Updates Document import to use langchain_core.documents instead of deprecated langchain.schema.document
server.jac Modernizes walker syntax to use Root entry and (?:Type) filters; modifies LLM configuration (has issue with verbose parameter placement)
server.impl.jac Wraps visitor.message with Text() constructor for type-safe parameter passing to respond_with_image/video methods
README.md Updates command from deprecated jac serve to current jac start

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


glob rag_engine:RagEngine = RagEngine();
glob llm = Model(model_name='gpt-4o-mini', verbose=True);
glob llm = Model(model_name='gpt-4o-mini',config={"verbose": False});
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verbose parameter should be a top-level parameter of the Model constructor, not inside the config dictionary. According to the byllm documentation and conventions used throughout the codebase (e.g., task_manager/byllm/BE/v1/main.jac:8), the config dictionary is reserved for advanced settings like api_base, http_client, and ca_bundle. The correct syntax should be: Model(model_name='gpt-4o-mini', verbose=False)

Suggested change
glob llm = Model(model_name='gpt-4o-mini',config={"verbose": False});
glob llm = Model(model_name='gpt-4o-mini', verbose=False);

Copilot uses AI. Check for mistakes.
@udithishanka udithishanka merged commit 2a704bb into jaseci-labs:main Feb 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants