fix: update Travel_planner application backend with the latest jaseci stack#484
fix: update Travel_planner application backend with the latest jaseci stack#484udithishanka merged 1 commit intojaseci-labs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Travel_planner application backend to align with the latest Jaseci stack by migrating to new syntax patterns and updated dependencies. The changes involve transitioning from deprecated Jac syntax patterns to the newer ?:Type filter syntax and updating the dependency from jac-cloud to jac-scale.
Changes:
- Updated Model initialization to use
configparameter forverbosesetting - Refactored traversal syntax from deprecated
`?Typepattern to?:Typepattern throughout the codebase - Replaced
jac-cloudwithjac-scalein requirements.txt - Updated ability triggers from
`root entrytoRoot entry
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Travel_planner/requirements.txt | Replaced jac-cloud dependency with jac-scale |
| Travel_planner/BE/agent_brain.jac | Updated Model initialization to use config dict for verbose parameter |
| Travel_planner/BE/agent_core.jac | Updated Model initialization and refactored traversal syntax from `?Type to ?:Type pattern |
| Travel_planner/BE/main.jac | Updated ability trigger syntax and refactored traversal filters to use ?:Type pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| node Session { | ||
| can generate_result with AgentVisitor entry { | ||
| if [-->](`?BaseAgent) { | ||
| if [-->](?:BaseAgent) { |
There was a problem hiding this comment.
Syntax inconsistency: The type filter should be inside the brackets, not outside. Line 13 uses [-->(?:Session)] (correct), but this line uses [-->](?:BaseAgent). This should be [-->(?:BaseAgent)] to match the syntax on line 13 and throughout agent_core.jac (line 202).
| if [-->](?:BaseAgent) { | |
| if [-->(?:BaseAgent)] { |
Modelin bothagent_brain.jacandagent_core.jacto use theconfigparameter for settingverboseinstead of a direct argument, aligning with the latest stack.agent_core.jacandmain.jacto use the new?:Typepattern instead of the deprecated'?Typepattern. Update `root with new type Root.jac-clouddependency withjac-scaleinrequirements.txt.